fix(RC-25445): use querySelectorPortal in pcln-menu and pcln-popover only when provided as a prop #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1510 +/- ##
=======================================
Coverage 93.75% 93.75%
=======================================
Files 149 149
Lines 11275 11275
Branches 690 685 -5
=======================================
Hits 10571 10571
Misses 685 685
Partials 19 19 ☔ View full report in Codecov by Sentry. |
sdalonzo
reviewed
Aug 12, 2024
packages/menu/src/Menu/Menu.jsx
Outdated
| @@ -69,14 +69,14 @@ function Menu({ | |||
| trapFocus={trapFocus} | |||
| width={width} | |||
| zIndex={zIndex} | |||
| querySelectorPortal={`.${querySelectorPortal}`} | |||
| querySelectorPortal={querySelectorPortal && `.${querySelectorPortal}`} | |||
There was a problem hiding this comment.
this would coerce to false. i think we want undefined (or construct the props and omit this if we don't want it). in that regard, it's not unlike Authorization header conversations.
querySelectorPortal ? `.${querySelectorPortal}` : undefined
There was a problem hiding this comment.
@sdalonzo thanks for flagging! updated
pcln-brianna
approved these changes
Aug 12, 2024
raclee7
changed the title
sdalonzo
approved these changes
Aug 12, 2024
akito470
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a hydration issue with
CurrencySelectorin@pcln/selectorswhile trying to migrate alt-landing app (which is only used for Airport Rental Cars landing page) to use DS6+React 18.@pcln/selectors > CurrencySelectoris used in@pcln/white-label-components>Header.@sdalonzo pointed out there was a bug with pcln-menu and pcln-popover (thank you!). In this PR I am making updates and adding test cases so that
querySelectorPortalis only used inpcln-menuandpcln-popoveronly when provided as a prop.