Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SITE-23502 - resolving SSR issues with carousel. #1512

Merged
merged 27 commits into from
Sep 10, 2024
Merged

SITE-23502 - resolving SSR issues with carousel. #1512

merged 27 commits into from
Sep 10, 2024

Conversation

Bsoong
Copy link
Collaborator

@Bsoong Bsoong commented Sep 9, 2024

Ticket: https://priceline.atlassian.net/browse/SITE-23502

Added a check for the global window before calling window functions to fix SSR issues experienced in next-landing

@Bsoong Bsoong changed the title Site 23502 SITE-23502 - resolving SSR issues with carousel. Sep 9, 2024
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.50%. Comparing base (9d11df9) to head (8fd54ec).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1512      +/-   ##
==========================================
+ Coverage   93.82%   94.50%   +0.67%     
==========================================
  Files         149      149              
  Lines       11275    11277       +2     
  Branches      691      693       +2     
==========================================
+ Hits        10579    10657      +78     
+ Misses        681      615      -66     
+ Partials       15        5      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bsoong Bsoong marked this pull request as ready for review September 9, 2024 16:09
@Bsoong Bsoong marked this pull request as draft September 9, 2024 17:27
@Bsoong Bsoong marked this pull request as ready for review September 9, 2024 20:11
Co-authored-by: Craig Palermo <3260642+craigpalermo@users.noreply.github.com>
@Bsoong Bsoong merged commit bb6340b into main Sep 10, 2024
10 checks passed
@Bsoong Bsoong deleted the SITE-23502 branch September 10, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants