Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLATFORM-1835]: Retire prima_rs_logger #85

Merged
merged 4 commits into from
Jun 20, 2024

Conversation

cpiemontese
Copy link
Contributor

@cpiemontese cpiemontese requested a review from a team as a code owner June 19, 2024 10:51
Copy link
Member

@MaeIsBad MaeIsBad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpiemontese
Copy link
Contributor Author

I tried adding a docker-compose but then when building a dependency (clap_m...something) it complains rust 1.74 is needed 🤔

@cpiemontese cpiemontese requested a review from MaeIsBad June 19, 2024 13:14
Copy link
Member

@MaeIsBad MaeIsBad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried adding a docker-compose but then when building a dependency (clap_m...something) it complains rust 1.74 is needed 🤔

not sure why you want a docker-compose, but you can just bump the rust version if you want to> I tried adding a docker-compose but then when building a dependency (clap_m...something) it complains rust 1.74 is needed 🤔

not sure why you want a docker-compose, but you can just bump the rust version if you want to

@cpiemontese
Copy link
Contributor Author

@MaeIsBad mainly because it has a nicer interface than base docker + Dockerfiles but it's just a preference

@cpiemontese cpiemontese merged commit d5b01ac into master Jun 20, 2024
7 checks passed
@cpiemontese cpiemontese deleted the PLATFORM-1835/task/retire-prima-rs-logger branch June 20, 2024 12:16
@MaeIsBad
Copy link
Member

For localauth0 I just do development on the host, since there aren't any other dependencies 🤷‍♀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants