Skip to content

Commit

Permalink
Refactor #3907 - For TieredMenu
Browse files Browse the repository at this point in the history
  • Loading branch information
tugcekucukoglu committed Apr 26, 2023
1 parent 09553cb commit 3ac7e6e
Show file tree
Hide file tree
Showing 4 changed files with 145 additions and 12 deletions.
6 changes: 6 additions & 0 deletions api-generator/components/tieredmenu.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,12 @@ const TieredMenuProps = [
type: 'boolean',
default: 'true',
description: "Whether to apply 'router-link-active-exact' class if route exactly matches the item path."
},
{
name: 'pt',
type: 'any',
default: 'null',
description: 'Uses to pass attributes to DOM elements inside the component.'
}
];

Expand Down
113 changes: 113 additions & 0 deletions components/lib/tieredmenu/TieredMenu.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,114 @@ import { VNode } from 'vue';
import { MenuItem } from '../menuitem';
import { ClassComponent, GlobalComponentConstructor } from '../ts-helpers';

export declare type TieredMenuPassThroughOptionType = TieredMenuPassThroughAttributes | ((options: TieredMenuPassThroughMethodOptions) => TieredMenuPassThroughAttributes) | null | undefined;

/**
* Custom passthrough(pt) option method.
*/
export interface TieredMenuPassThroughMethodOptions {
props: TieredMenuProps;
state: TieredMenuState;
}

/**
* Custom passthrough(pt) options.
* @see {@link TieredMenuProps.pt}
*/
export interface TieredMenuPassThroughOptions {
/**
* Uses to pass attributes to the root's DOM element.
*/
root?: TieredMenuPassThroughOptionType;
/**
* Uses to pass attributes to the list's DOM element.
*/
menu?: TieredMenuPassThroughOptionType;
/**
* Uses to pass attributes to the list item's DOM element.
*/
menuitem?: TieredMenuPassThroughOptionType;
/**
* Uses to pass attributes to the content's DOM element.
*/
content?: TieredMenuPassThroughOptionType;
/**
* Uses to pass attributes to the action's DOM element.
*/
action?: TieredMenuPassThroughOptionType;
/**
* Uses to pass attributes to the icon's DOM element.
*/
icon?: TieredMenuPassThroughOptionType;
/**
* Uses to pass attributes to the label's DOM element.
*/
label?: TieredMenuPassThroughOptionType;
/**
* Uses to pass attributes to the submenu icon's DOM element.
*/
submenuIcon?: TieredMenuPassThroughOptionType;
/**
* Uses to pass attributes to the separator's DOM element.
*/
separator?: TieredMenuPassThroughOptionType;
}

/**
* Custom passthrough attributes for each DOM elements
*/
export interface TieredMenuPassThroughAttributes {
[key: string]: any;
}

/**
* Defines focused item info
*/
export interface TieredMenuFocusedItemInfo {
/**
* Active item index
*/
index: number;
/**
* Active item level
*/
level: number;
/**
* Parent key info
*/
parentKey: string;
}

/**
* Defines current inline state in TieredMenu component.
*/
export interface TieredMenuState {
/**
* Current id state as a string.
*/
id: string;
/**
* Current focus state as a boolean.
* @defaultValue false
*/
focused: boolean;
/**
* Current focused item info.
* @type {TieredMenuFocusedItemInfo}
*/
focusedItemInfo: TieredMenuFocusedItemInfo;
/**
* Active item path.
* @type {TieredMenuFocusedItemInfo}
*/
activeItemPath: TieredMenuFocusedItemInfo[];
/**
* Current visible state as a boolean.
* @defaultValue true
*/
visible: boolean;
}

/**
* Defines valid properties in TieredMenuMenu component.
*/
Expand Down Expand Up @@ -61,6 +169,11 @@ export interface TieredMenuProps {
* Identifier of the underlying menu element.
*/
'aria-labelledby'?: string | undefined;
/**
* Uses to pass attributes to DOM elements inside the component.
* @type {TieredMenuPassThroughOptions}
*/
pt?: TieredMenuPassThroughOptions;
}

/**
Expand Down
5 changes: 4 additions & 1 deletion components/lib/tieredmenu/TieredMenu.vue
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<template>
<Portal :appendTo="appendTo" :disabled="!popup">
<transition name="p-connected-overlay" @enter="onEnter" @after-enter="onAfterEnter" @leave="onLeave" @after-leave="onAfterLeave">
<div v-if="visible" :ref="containerRef" :id="id" :class="containerClass" @click="onOverlayClick" v-bind="$attrs">
<div v-if="visible" :ref="containerRef" :id="id" :class="containerClass" @click="onOverlayClick" v-bind="{ ...$attrs, ...ptm('root') }">
<TieredMenuSub
:ref="menubarRef"
:id="id + '_list'"
Expand All @@ -20,6 +20,7 @@
:activeItemPath="activeItemPath"
:exact="exact"
:level="0"
:pt="pt"
@focus="onFocus"
@blur="onBlur"
@keydown="onKeyDown"
Expand All @@ -32,13 +33,15 @@
</template>

<script>
import BaseComponent from 'primevue/basecomponent';
import OverlayEventBus from 'primevue/overlayeventbus';
import Portal from 'primevue/portal';
import { ConnectedOverlayScrollHandler, DomHandler, ObjectUtils, UniqueComponentId, ZIndexUtils } from 'primevue/utils';
import TieredMenuSub from './TieredMenuSub.vue';
export default {
name: 'TieredMenu',
extends: BaseComponent,
inheritAttrs: false,
emits: ['focus', 'blur', 'before-show', 'before-hide', 'hide', 'show'],
props: {
Expand Down
33 changes: 22 additions & 11 deletions components/lib/tieredmenu/TieredMenuSub.vue
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<ul>
<ul v-bind="ptm('menu')">
<template v-for="(processedItem, index) of items" :key="getItemKey(processedItem)">
<li
v-if="isItemVisible(processedItem) && !getItemProp(processedItem, 'separator')"
Expand All @@ -14,23 +14,24 @@
:aria-level="level + 1"
:aria-setsize="getAriaSetSize()"
:aria-posinset="getAriaPosInset(index)"
v-bind="ptm('menuitem')"
>
<div class="p-menuitem-content" @click="onItemClick($event, processedItem)" @mouseenter="onItemMouseEnter($event, processedItem)">
<div class="p-menuitem-content" @click="onItemClick($event, processedItem)" @mouseenter="onItemMouseEnter($event, processedItem)" v-bind="ptm('content')">
<template v-if="!templates.item">
<router-link v-if="getItemProp(processedItem, 'to') && !isItemDisabled(processedItem)" v-slot="{ navigate, href, isActive, isExactActive }" :to="getItemProp(processedItem, 'to')" custom>
<a v-ripple :href="href" :class="getItemActionClass(processedItem, { isActive, isExactActive })" tabindex="-1" aria-hidden="true" @click="onItemActionClick($event, navigate)">
<a v-ripple :href="href" :class="getItemActionClass(processedItem, { isActive, isExactActive })" tabindex="-1" aria-hidden="true" @click="onItemActionClick($event, navigate)" v-bind="ptm('action')">
<component v-if="templates.itemicon" :is="templates.itemicon" :item="processedItem.item" :class="getItemIconClass(processedItem)" />
<span v-else-if="getItemProp(processedItem, 'icon')" :class="getItemIconClass(processedItem)" />
<span class="p-menuitem-text">{{ getItemLabel(processedItem) }}</span>
<span v-else-if="getItemProp(processedItem, 'icon')" :class="getItemIconClass(processedItem)" v-bind="ptm('icon')" />
<span class="p-menuitem-text" v-bind="ptm('label')">{{ getItemLabel(processedItem) }}</span>
</a>
</router-link>
<a v-else v-ripple :href="getItemProp(processedItem, 'url')" :class="getItemActionClass(processedItem)" :target="getItemProp(processedItem, 'target')" tabindex="-1" aria-hidden="true">
<a v-else v-ripple :href="getItemProp(processedItem, 'url')" :class="getItemActionClass(processedItem)" :target="getItemProp(processedItem, 'target')" tabindex="-1" aria-hidden="true" v-bind="ptm('action')">
<component v-if="templates.itemicon" :is="templates.itemicon" :item="processedItem.item" :class="getItemIconClass(processedItem)" />
<span v-else-if="getItemProp(processedItem, 'icon')" :class="getItemIconClass(processedItem)" />
<span class="p-menuitem-text">{{ getItemLabel(processedItem) }}</span>
<span v-else-if="getItemProp(processedItem, 'icon')" :class="getItemIconClass(processedItem)" v-bind="ptm('icon')" />
<span class="p-menuitem-text" v-bind="ptm('text')">{{ getItemLabel(processedItem) }}</span>
<template v-if="getItemProp(processedItem, 'items')">
<component v-if="templates.submenuicon" :is="templates.submenuicon" class="p-submenu-icon" :active="isItemActive(processedItem)" />
<AngleRightIcon v-else class="p-submenu-icon" />
<component v-if="templates.submenuicon" :is="templates.submenuicon" class="p-submenu-icon" :active="isItemActive(processedItem)" v-bind="ptm('submenuicon')" />
<AngleRightIcon v-else class="p-submenu-icon" v-bind="ptm('submenuicon')" />
</template>
</a>
</template>
Expand All @@ -48,22 +49,32 @@
:activeItemPath="activeItemPath"
:exact="exact"
:level="level + 1"
:pt="pt"
@item-click="$emit('item-click', $event)"
@item-mouseenter="$emit('item-mouseenter', $event)"
/>
</li>
<li v-if="isItemVisible(processedItem) && getItemProp(processedItem, 'separator')" :id="getItemId(processedItem)" :style="getItemProp(processedItem, 'style')" :class="getSeparatorItemClass(processedItem)" role="separator"></li>
<li
v-if="isItemVisible(processedItem) && getItemProp(processedItem, 'separator')"
:id="getItemId(processedItem)"
:style="getItemProp(processedItem, 'style')"
:class="getSeparatorItemClass(processedItem)"
role="separator"
v-bind="ptm('separator')"
></li>
</template>
</ul>
</template>

<script>
import BaseComponent from 'primevue/basecomponent';
import AngleRightIcon from 'primevue/icons/angleright';
import Ripple from 'primevue/ripple';
import { ObjectUtils } from 'primevue/utils';
export default {
name: 'TieredMenuSub',
extends: BaseComponent,
emits: ['item-click', 'item-mouseenter'],
props: {
menuId: {
Expand Down

0 comments on commit 3ac7e6e

Please sign in to comment.