Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfirmDialog: closeOnEscape support #2675

Closed
mauritsderoover opened this issue Jun 15, 2022 · 0 comments
Closed

ConfirmDialog: closeOnEscape support #2675

mauritsderoover opened this issue Jun 15, 2022 · 0 comments
Assignees
@tugcekucukoglu
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
3.16.0

Comments

@mauritsderoover
Copy link

Describe the feature you would like to see added

We would like the option to disable closeOnEscape in the ConfirmDialog so that our users can't simply press escape to avoid the confirmation.

Is your feature request related to a problem?

No response

Describe the solution you'd like

We would like a closeOnEscape prop in the ConfirmDialog which is then passed to the Dialog component. This way we would have the power to decide whether we want to allow closeOnEscape or not.

Describe alternatives you have considered

No response

Additional context

No response
@mauritsderoover mauritsderoover added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Jun 15, 2022
@tugcekucukoglu tugcekucukoglu added this to the 3.x milestone Jun 28, 2022
@tugcekucukoglu tugcekucukoglu self-assigned this Jun 28, 2022
@tugcekucukoglu tugcekucukoglu modified the milestones: 3.x, 3.15.1 Jul 1, 2022
@tugcekucukoglu tugcekucukoglu changed the title ConfirmDialog: closeOnEscape ConfirmDialog: closeOnEscape support Jul 1, 2022
tugcekucukoglu added a commit that referenced this issue Jul 1, 2022
@tugcekucukoglu
Merge pull request #2743 from tugcekucukoglu/confirm-dialog
17c8d0b 
Fixed #2675 - ConfirmDialog: closeOnEscape support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
3.16.0
Development

No branches or pull requests
2 participants
@tugcekucukoglu @mauritsderoover