Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Dialog : style property TypeScript error #2699

Closed
James-Laidlaw opened this issue Jun 21, 2022 · 1 comment
Closed

Dynamic Dialog : style property TypeScript error #2699

James-Laidlaw opened this issue Jun 21, 2022 · 1 comment
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@James-Laidlaw
Copy link
Contributor

Describe the bug

Type definition for dynamic dialog is missing style property, causing typescript to raise an incorrect error when styling a dynamic dialog. bug found when using composition API.

Bug fix push request already made. just making this error for documentation

Reproducer

No response

PrimeVue version

3.15.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

  1. make a dynamic dialog using composition api and typescript
  2. try to style it using a line like this
dialog.open(aValidComponent, {
    props: {
      style: "width: 30vw",
    },
  });
  1. observe error line

Expected behavior

style should be a valid property of the dialog prop object.

@James-Laidlaw James-Laidlaw added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Jun 21, 2022
@James-Laidlaw
Copy link
Contributor Author

pull request for this issue
#2700
' Fixed DialogProps type error issue: "Component: Dynamic Dialog #2699" #2700 '

@tugcekucukoglu tugcekucukoglu changed the title Component: Dynamic Dialog Dynamic Dialog : style property TypeScript error Jun 28, 2022
@tugcekucukoglu tugcekucukoglu added this to the 3.15.1 milestone Jun 28, 2022
@tugcekucukoglu tugcekucukoglu self-assigned this Jun 28, 2022
tugcekucukoglu added a commit that referenced this issue Jun 28, 2022
Fixed #2699 - Dynamic Dialog : style property TypeScript error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants