Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkbox: Icon slot does not provide information about the indeterminate state #5942

Closed
m-meier opened this issue Jun 21, 2024 · 0 comments · Fixed by #5943 · May be fixed by gn00029914/vite-app-demo#192
Closed

Checkbox: Icon slot does not provide information about the indeterminate state #5942

m-meier opened this issue Jun 21, 2024 · 0 comments · Fixed by #5943 · May be fixed by gn00029914/vite-app-demo#192
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
4.0.0-rc.3

Comments

@m-meier
Copy link
Contributor

m-meier commented Jun 21, 2024

Describe the bug

Currently only the checked state is provided to the icon slot. This makes it impossible to customize the indeterminate or the unchecked icon when using indeterminate, since you can only check for checked=false which is the case for indeterminate as well as unchecked.

Reproducer

https://stackblitz.com/edit/vitejs-vite-g2fmnw?file=src%2FApp.vue

PrimeVue version

4.0.0-rc.2

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

The icon slot should provide information about the indeterminate state
@m-meier m-meier added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jun 21, 2024
@m-meier m-meier mentioned this issue Jun 21, 2024
Merged
tugcekucukoglu added a commit that referenced this issue Jun 24, 2024
@tugcekucukoglu
Merge pull request #5943 from m-meier/patch-8
337485d 
feat(Checkbox): add indeterminate state to icon slot, fixes #5942
@tugcekucukoglu tugcekucukoglu added this to the 4.0.0-rc.3 milestone Jun 27, 2024
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jun 27, 2024
@gn00029914 gn00029914 mentioned this issue Jul 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
4.0.0-rc.3
2 participants
@m-meier @tugcekucukoglu