Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar: reimplement #3465

Merged
merged 5 commits into from
Jan 9, 2023
Merged

Sidebar: reimplement #3465

merged 5 commits into from
Jan 9, 2023

Conversation

bahadirsofuoglu
Copy link
Contributor

@bahadirsofuoglu bahadirsofuoglu commented Dec 30, 2022

Completed #3474 - Fixed #1823

@github-actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@github-actions github-actions bot added the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Dec 30, 2022
@github-actions
Copy link

github-actions bot commented Jan 3, 2023

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@bahadirsofuoglu bahadirsofuoglu marked this pull request as ready for review January 3, 2023 14:30
@github-actions
Copy link

github-actions bot commented Jan 3, 2023

Thanks a lot for your contribution! But, Unit tests failed. You can check the unit tests with the command 'npm run test:unit' and commit the changes.

@github-actions
Copy link

github-actions bot commented Jan 3, 2023

Thanks a lot for your contribution! But, Unit tests failed. You can check the unit tests with the command 'npm run test:unit' and commit the changes.

@bahadirsofuoglu bahadirsofuoglu changed the title Sidebar: after changing position mask not removed issue fixed Sidebar: reimplement Jan 3, 2023
@github-actions github-actions bot removed the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Jan 3, 2023
@bahadirsofuoglu bahadirsofuoglu merged commit 92f0f1b into master Jan 9, 2023
@bahadirsofuoglu bahadirsofuoglu deleted the issue-1823 branch January 9, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar overlay not removed after changing position
1 participant