-
Notifications
You must be signed in to change notification settings - Fork 32
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
36 changed files
with
1,652 additions
and
196 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
--- | ||
'@primer/react-brand': minor | ||
--- | ||
|
||
Improved a11y labelling in various components. | ||
|
||
Please note these changes could affect any behavioral tests, which rely on accessible matchers such as `getByRole`. | ||
|
||
- `SubdomainNavBar` search button `aria-label` changed from 'search' to 'Toggle search bar' | ||
- `SubdomainNavBar` removal of unnecessary `aria-label` 'global breadcrumb' | ||
- `Checkbox` addition of new label for `checked` state icon as 'Checkmark' | ||
- `Checkbox` addition of new label for `indeterminate` state icon as 'Dash icon' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
--- | ||
'@primer/brand-primitives': minor | ||
--- | ||
|
||
Change to `xxlarge` breakpoint and the addition of two new base scale size tokens. | ||
|
||
Outcome of an upgrade to Primer Primitives `v9` release. | ||
|
||
```diff | ||
+ --base-size-2: 0.125rem; | ||
``` | ||
|
||
```diff | ||
+ --base-size-6: 0.375rem; | ||
``` | ||
|
||
```diff | ||
- --brand-breakpoint-xxlarge: 90rem; | ||
+ --brand-breakpoint-xxlarge: 87.5rem; | ||
``` | ||
|
||
```diff | ||
- @custom-media --brand-viewportRange-wide-viewport (min-width: 90rem); | ||
+ @custom-media --brand-viewportRange-wide-viewport (min-width: 87.5rem); | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.