Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add site title to SubdomainNavBar menu on narrow viewports #524

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

rezrah
Copy link
Collaborator

@rezrah rezrah commented Jan 24, 2024

Summary

Adds the previously missing site title to the SubdomainNavBar menu on narrow viewports.

Resolves #514

This change resolves the issue by ensuring that the site title is visible (and not hidden/missing) to users on narrow viewports, even if it is located inside the menu.

🔗 Try it here

List of notable changes:

  • added site title to the mobile menu above the main links, to ensure that site title is available for users on narrow viewports.

What should reviewers focus on?

  • Location of the link

Steps to test:

  1. Use this story to test the changes

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • New visual snapshots have been generated / updated for any UI changes
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Screenshot 2024-01-24 at 16 15 12

Copy link

changeset-bot bot commented Jan 24, 2024

🦋 Changeset detected

Latest commit: 9c906e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@primer/react-brand Patch
@primer/brand-primitives Patch
@primer/brand-e2e Patch
@primer/brand-fonts Patch
@primer/brand-config Patch
@primer/brand-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 24, 2024

🟢 No design token changes found

Copy link
Contributor

github-actions bot commented Jan 24, 2024

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

Copy link
Contributor

@danielguillan danielguillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@rezrah rezrah merged commit 365e01e into main Jan 25, 2024
15 of 16 checks passed
@rezrah rezrah deleted the rezrah/subdomain-title-in-menu branch January 25, 2024 16:22
@primer-css primer-css mentioned this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Accessibility] SubdomainNavBar misses controls when narrow
2 participants