-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolves #528 - spread props on HeroDescription #529
Conversation
🦋 Changeset detectedLatest commit: 63fc524 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the update @alexbuiltit. The changes looks good. One minor suggestion for the change log, but otherwise happy to ✨
Co-authored-by: Rez <13340707+rezrah@users.noreply.github.com>
Hey @rezrah I've approved your suggestion, is there anything else I need to do or best to leave it with you/the team for now? |
👍 Thanks for resolving this issue @alexbuiltit, and for contributing to Primer. I'll get this merged for you now. |
Summary
Minor change that resolves #528 - allowing users to add custom class names to the
HeroDescription
componentList of notable changes:
{...rest}
toHeroDescription
to allow for custom class names to be used, this pattern is being used inHeroHeading
,HeroImage
etc.What should reviewers focus on?
One thing to consider is that when a custom class name is being used it will remove the
Hero-description
styles, this is existing behaviour on theHeroHeading
therefore isn't a regression.Steps to test:
Hero.stories.tsx
file and include aclassName
on theHeroDescription
component.Contributor checklist:
Reviewer checklist: