-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use more semantic elements in SubNav #711
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a81042a The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🟢 No design token changes found |
joshfarrant
force-pushed
the
joshfarrant/a11y-3800
branch
from
August 22, 2024 11:36
42ab237
to
96c3846
Compare
joshfarrant
commented
Aug 22, 2024
...c/SubNav/SubNav.visual.spec.ts-snapshots/Visual-Comparison-SubNav-SubNav-Default-1-linux.png
Outdated
Show resolved
Hide resolved
joshfarrant
temporarily deployed
to
github-pages
August 22, 2024 12:01
— with
GitHub Actions
Inactive
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
joshfarrant
temporarily deployed
to
github-pages
August 22, 2024 13:05
— with
GitHub Actions
Inactive
rezrah
reviewed
Aug 28, 2024
rezrah
reviewed
Aug 28, 2024
joshfarrant
temporarily deployed
to
github-pages
August 29, 2024 09:21
— with
GitHub Actions
Inactive
rezrah
reviewed
Aug 29, 2024
rezrah
approved these changes
Aug 29, 2024
...rison-SubNav-Mobile-viewport-test-for-Full-Width-Narrow-SubNav-Full-Width-Narrow-1-linux.png
Outdated
Show resolved
Hide resolved
danielguillan
approved these changes
Aug 29, 2024
joshfarrant
temporarily deployed
to
github-pages
August 29, 2024 11:27
— with
GitHub Actions
Inactive
Merged
This was referenced Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace
div
elements with more semanticul
andli
elements in the SubNav component.List of notable changes:
div
elements withul
andli
elements.What should reviewers focus on?
Supporting resources (related issues, external links, etc):
Contributor checklist:
Reviewer checklist: