Hide paged items in Pagination component on narrow viewports #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt horizontal scrolling
🦋 Changeset detectedLatest commit: a28be6c The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🟢 No design token changes found |
rezrah
commented
Aug 23, 2024
| @@ -76,6 +76,7 @@ describe('BreakoutBanner', () => { | |||
| it('renders primary link with arrow by default', () => { | |||
| const {getAllByRole} = render( | |||
| <BreakoutBanner> | |||
| <BreakoutBanner.Heading>Required heading</BreakoutBanner.Heading> | |||
There was a problem hiding this comment.
FYI: Unrelated to the pagination change. This fixes some noisy test logs.
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
Merged
This was referenced Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves https://github.com/github/primer/issues/3744
Numbered pagination items are now hidden on narrow viewports by default. This prevents horizontal overflow / scrolling issues when a large number of items are present.
While the API already supports
showPages, this enforces that behavior by default while retaining the option to customize it.🔗 Storybook preview
List of notable changes:
showPagesnow undefined by default (prevtrue)showPagesistrueif viewport is >isMediumshowPagescontinues to be customizable and forwarded by end-users (backwards compatible)What should reviewers focus on?
Steps to test:
Supporting resources (related issues, external links, etc):
Contributor checklist:
Reviewer checklist:
Screenshots: