-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup by removing some unneeded transforms and moving a format into a file #741
Conversation
|
🟢 No design token changes found |
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
@@ -36,9 +36,7 @@ | |||
"@primer/primitives": "9.1.0", | |||
"prettier": "^2.8.8", | |||
"@prettier/sync": "^0.5.2", | |||
"color2k": "^2.0.2", | |||
"fast-glob": "3.3.2", | |||
"style-dictionary": "3.8.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Will leave the v4 upgrade with you then 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not essential for this, but might be nice to have a test for this, to help with future refactors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can upstream this.
306d760
to
fa150dd
Compare
Summary
List of notable changes:
What should reviewers focus on?
Steps to test:
Supporting resources (related issues, external links, etc):
Contributor checklist:
Reviewer checklist:
Screenshots: