Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new color Labels #1711

Merged
merged 3 commits into from
Oct 28, 2021
Merged

Add new color Labels #1711

merged 3 commits into from
Oct 28, 2021

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Oct 28, 2021

This adds a few new colored Labels to match the color roles in Primitives.

Before

Screen Shot 2021-10-28 at 15 41 26

After

Screen Shot 2021-10-28 at 15 42 42

This is part of https://github.com/github/primer/issues/331. On dotcom we still have a few deprecated Labels. Once this PR is published, we can replace them like:

Before After
Label--info Label--accent
Label--warning Label--attention
Label--orange Label--severe
Label--purple Label--done
Label--pink Label--sponsors

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: 6d9fd00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@simurai simurai marked this pull request as ready for review October 28, 2021 06:59
@simurai simurai requested a review from a team as a code owner October 28, 2021 06:59
jonrohan
jonrohan approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been waiting on that Label--sponsors so we can remove Label--pink

@jonrohan jonrohan enabled auto-merge (squash) October 28, 2021 17:33
@jonrohan jonrohan merged commit bc3b94d into main Oct 28, 2021
@jonrohan jonrohan deleted the label-roles branch October 28, 2021 17:34
@primer-css primer-css mentioned this pull request Oct 28, 2021
Merged
This was referenced Oct 29, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

@auareyou auareyou Awaiting requested review from auareyou

Assignees
No one assigned
Labels
minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simurai @jonrohan