Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout gutter none styles #1882

Merged
merged 2 commits into from
Jan 18, 2022
Merged

Fix layout gutter none styles #1882

merged 2 commits into from
Jan 18, 2022

Conversation

tqwewe
Copy link
Contributor

@tqwewe tqwewe commented Jan 15, 2022

What are you trying to accomplish?

Fix #1880.

What approach did you choose and why?

The fix is a simple matter of adding px to the value.

What should reviewers focus on?

Issue #1880.

Are additional changes needed?

  • No, this PR should be ok to ship as is. 🚢

@tqwewe tqwewe requested a review from a team as a code owner January 15, 2022 13:30
@changeset-bot
Copy link

changeset-bot bot commented Jan 15, 2022

🦋 Changeset detected

Latest commit: 23c1115

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's wild that the grid template columns doesn't like the unitless 0. Thanks for the contribution! 👍🏻

@jonrohan jonrohan merged commit 4a06aba into primer:main Jan 18, 2022
@primer-css primer-css mentioned this pull request Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout--gutter-none results in wrong behaviour
2 participants