Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correcting missing images #1932

Closed
wants to merge 1 commit into from
Closed

Correcting missing images #1932

wants to merge 1 commit into from

Conversation

abdounikarim
Copy link

Hey, I propose a quick fix for the missing images. Issue linked : #722

@abdounikarim abdounikarim requested a review from a team as a code owner February 7, 2022 07:54
@changeset-bot
Copy link

changeset-bot bot commented Feb 7, 2022

⚠️ No Changeset found

Latest commit: e60cc5c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@simurai
Copy link
Contributor

simurai commented Feb 9, 2022 •
edited
Loading

@abdounikarim Thanks for the PR. 🙇

I'm gonna close this as a wontfix. Because we now have color modes we are moving to replace those gif and pngs to svg that can adapt to different themes. We also plan to overhaul the Form group validation and probably won't be using background-image: to add icons.

If the current paths don't work for your app, you could override it to your own file structure. For example add the my-app (or your own name) to the <html> element and then the following styles:

.my-app .form-group > .form-group-body {
  .form-control {
    &.is-autocheck-loading {
      background-image: url('../images/spinners/octocat-spinner-16px.gif');
    }

    &.is-autocheck-successful {
      background-image: url('../images/modules/ajax/success.png');
    }

    &.is-autocheck-errored {
      background-image: url('../images/modules/ajax/error.png');
    }
  }
}

@simurai simurai closed this Feb 9, 2022
@abdounikarim
Copy link
Author

@simurai thanks for your answer 😉

Can you link your answer to this issue please ? So people can know how to handle this ?

Cheers 😉

@simurai simurai mentioned this pull request Feb 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan Awaiting requested review from jonrohan jonrohan was automatically assigned from primer/css-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abdounikarim @simurai