Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize: use --color-fg-default on mark #2309

Merged
merged 2 commits into from
Dec 16, 2022

Conversation

jdanyow
Copy link
Contributor

@jdanyow jdanyow commented Nov 15, 2022

The style for <mark> uses --color-text-primary which is no longer defined on github.com/primer.

CleanShot 2022-11-26 at 19 06 06@2x

@jdanyow jdanyow requested a review from a team as a code owner November 15, 2022 14:16
@changeset-bot
Copy link

changeset-bot bot commented Nov 15, 2022

🦋 Changeset detected

Latest commit: ae5c7cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@simurai simurai enabled auto-merge (squash) December 16, 2022 00:26
Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply. 🙇

Yes, good catch! 👍

@simurai simurai merged commit f76e785 into primer:main Dec 16, 2022
@primer-css primer-css mentioned this pull request Dec 16, 2022
@jdanyow jdanyow deleted the jd/normalize-mark branch December 17, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants