Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import blankslate styles from primer/view-components #2318

Merged
merged 5 commits into from
Nov 22, 2022

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Nov 18, 2022

What are you trying to accomplish?

This starts the work for https://github.com/github/primer/issues/1444 pulling in the styles migrated to primer/view_components#1584

What should reviewers focus on?

This shouldn't effect the overall output of the css, it's only being managed in https://github.com/primer/view_components/ now

Can these changes ship as is?

  • Yes, this PR does not depend on additional changes. 🚢

@jonrohan jonrohan requested a review from a team as a code owner November 18, 2022 22:04
@jonrohan jonrohan requested a review from langermank November 18, 2022 22:04
@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2022

🦋 Changeset detected

Latest commit: 30c3573

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonrohan jonrohan changed the title Import blankslate styles from primer/view-components Import blankslate styles from primer/view-components Nov 18, 2022
@jonrohan jonrohan temporarily deployed to github-pages November 18, 2022 22:13 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview November 18, 2022 22:13 Inactive
@jonrohan jonrohan temporarily deployed to github-pages November 18, 2022 22:23 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview November 18, 2022 22:23 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview November 22, 2022 18:17 Inactive
@jonrohan jonrohan merged commit aee4b6f into main Nov 22, 2022
@jonrohan jonrohan deleted the import_from_pvc/blankslate branch November 22, 2022 18:21
@primer-css primer-css mentioned this pull request Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants