Move some form styles to base.scss

[simurai]

What are you trying to accomplish?

This moves the

• fieldset
• label
• ::placeholder

styles to base.scss.

What approach did you choose and why?

This is in support of primer/view_components#1638.

I think we shouldn't move all of the old form-control.scss styles to PVC. But specifically the fieldset + ::placeholder are still needed in PVC. So making them part of base.scss feels like a good approach to make them more broadly available. They also don't use a class but instead use the element as selector. So having them in base.scss seems a good place.

What should reviewers focus on?

Any alternative? We could also move it to normalize.scss

Can these changes ship as is?

• Yes, this PR does not depend on additional changes. 🚢

[changeset-bot]

🦋 Changeset detected

Latest commit: 171b415

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/css	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR