Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop “display: none” from details element contents styling #2624

Conversation

sideshowbarker
Copy link
Contributor

What are you trying to accomplish?

Fixes #2592

What approach did you choose and why?

Removed display: none from details contents styling

What should reviewers focus on?

See #2592 (comment) for repro/test steps

Can these changes ship as is?

  • Yes, this PR does not depend on additional changes. 🚢

@sideshowbarker sideshowbarker requested a review from a team as a code owner May 9, 2024 11:49
@sideshowbarker sideshowbarker requested a review from emilybrick May 9, 2024 11:49
Copy link

changeset-bot bot commented May 9, 2024

🦋 Changeset detected

Latest commit: 887edd8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sideshowbarker sideshowbarker force-pushed the drop-display-none-from-details-contents-styling branch from 62952f8 to 887edd8 Compare May 9, 2024 11:56
Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was likely around for IE11 which we've long since dropped support for. Originally added in #371 in 2017.

As far as I can tell all browsers we see traffic GitHub support <details> and therefore don't need this. So 👍 from me.

Copy link
Contributor

github-actions bot commented Jul 8, 2024

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

@github-actions github-actions bot added the Stale Automatically marked as stale. label Jul 8, 2024
@sideshowbarker
Copy link
Contributor Author

Friendly ping to reviewers

@github-actions github-actions bot removed the Stale Automatically marked as stale. label Jul 8, 2024
@keithamus
Copy link
Member

Thanks for the ping @sideshowbarker. I’ll look at integrating this tomorrow and if it works out nicely we can look to ship it this week.

@keithamus keithamus merged commit 7e62532 into primer:main Jul 9, 2024
10 of 12 checks passed
@primer primer bot mentioned this pull request Jul 9, 2024
@sideshowbarker sideshowbarker deleted the drop-display-none-from-details-contents-styling branch July 9, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants