Skip to content
This repository has been archived by the owner on Mar 31, 2020. It is now read-only.

Use action-status #4

Merged
merged 6 commits into from
Feb 5, 2019
Merged

Use action-status #4

merged 6 commits into from
Feb 5, 2019

Conversation

shawnbot
Copy link
Contributor

@shawnbot shawnbot commented Feb 5, 2019

⚠️ Note: this branches off #3, so we should merge that first.

This replaces commit-status with action-status, which does the same thing but doesn't require any additional configuration in the GitHub Actions environment.

My plan here was initially to support configuring the statuses via an @primer/deploy key in package.json, but after testing it out I realized that there isn't much value in having that if all of the alias status checks get the same configuration.

@shawnbot shawnbot changed the title [WIP] Use action-status Use action-status Feb 5, 2019
@shawnbot shawnbot requested a review from emplums February 5, 2019 20:58
@shawnbot shawnbot changed the base branch from master to bracket-entrypoint February 5, 2019 20:58
Copy link
Contributor

@emplums emplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@shawnbot shawnbot changed the base branch from bracket-entrypoint to master February 5, 2019 21:45
@shawnbot shawnbot merged commit 18136e8 into master Feb 5, 2019
@shawnbot shawnbot deleted the status-config branch February 5, 2019 21:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants