Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Goal icons #873

Merged
merged 8 commits into from
Nov 30, 2022
Merged

Add Goal icons #873

merged 8 commits into from
Nov 30, 2022

Conversation

gavinmn
Copy link
Contributor

@gavinmn gavinmn commented Nov 22, 2022

@gavinmn gavinmn requested a review from a team as a code owner November 22, 2022 20:30
@changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 84ce5fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/octicons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gavinmn gavinmn temporarily deployed to github-pages November 22, 2022 20:36 Inactive
@colebemis
Copy link
Contributor

Love it! 😍

Have you tried using a 0.25px corner radius on the end of the arrow for consistency with other icons?

CleanShot 2022-11-22 at 14 34 41@2x

Here's the section about that in the design guidelines: https://primer.style/octicons/guidelines/design#corners

@gavinmn
Copy link
Contributor Author

gavinmn commented Nov 28, 2022

@colebemis that's a great call! I had originally tried this but got a result that was much too round so I went with a 0 px radius. I just realized tho that it was because I was applying the rounding to the icon before flattening it. I just commited some new icons that should fix this inconsistency.

@colebemis colebemis temporarily deployed to github-pages November 28, 2022 23:00 Inactive
@gavinmn
Copy link
Contributor Author

gavinmn commented Nov 29, 2022

@colebemis is this good to go?

colebemis
colebemis approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it 🎯

@gavinmn gavinmn merged commit 0d1b1ff into main Nov 30, 2022
@gavinmn gavinmn deleted the goal-icon branch November 30, 2022 18:40
@primer-css primer-css mentioned this pull request Dec 13, 2022
Merged
@skemex skemex mentioned this pull request May 24, 2024
Open
@soumen1102 soumen1102 mentioned this pull request Jun 20, 2024
Open
@rbragaru rbragaru mentioned this pull request Aug 14, 2024
Open
This was referenced Sep 9, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colebemis colebemis colebemis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gavinmn @colebemis @actions-user