Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some follow-up fixes #542

Merged
merged 3 commits into from
Mar 29, 2023
Merged

some follow-up fixes #542

merged 3 commits into from
Mar 29, 2023

Conversation

lukasoppermann
Copy link
Contributor

Summary

Some additional minor a11y improvements

@lukasoppermann lukasoppermann requested a review from a team as a code owner March 29, 2023 12:26
@changeset-bot
Copy link

changeset-bot bot commented Mar 29, 2023

🦋 Changeset detected

Latest commit: 5be1175

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2023

Variables changed
--- base/dist/scss/colors/_dark.scss	2023-03-29 12:52:55.624499264 +0000
+++ dist/scss/colors/_dark.scss	2023-03-29 12:51:52.579434379 +0000
@@ -107,3 +107,3 @@
     --color-checks-line-hover-bg: rgba(110,118,129,0.1);
-    --color-checks-line-selected-bg: rgba(56,139,253,0.15);
+    --color-checks-line-selected-bg: rgba(56,139,253,0.1);
     --color-checks-line-selected-num-text: #2f81f7;
@@ -309,3 +309,3 @@
     --color-accent-muted: rgba(56,139,253,0.4);
-    --color-accent-subtle: rgba(56,139,253,0.15);
+    --color-accent-subtle: rgba(56,139,253,0.1);
     --color-success-fg: #3fb950;
--- base/dist/scss/colors/_dark_colorblind.scss	2023-03-29 12:52:55.652499739 +0000
+++ dist/scss/colors/_dark_colorblind.scss	2023-03-29 12:51:52.591434584 +0000
@@ -107,3 +107,3 @@
     --color-checks-line-hover-bg: rgba(110,118,129,0.1);
-    --color-checks-line-selected-bg: rgba(56,139,253,0.15);
+    --color-checks-line-selected-bg: rgba(56,139,253,0.1);
     --color-checks-line-selected-num-text: #2f81f7;
@@ -309,3 +309,3 @@
     --color-accent-muted: rgba(56,139,253,0.4);
-    --color-accent-subtle: rgba(56,139,253,0.15);
+    --color-accent-subtle: rgba(56,139,253,0.1);
     --color-success-fg: #58a6ff;
--- base/dist/scss/colors/_dark_dimmed.scss	2023-03-29 12:52:55.636499468 +0000
+++ dist/scss/colors/_dark_dimmed.scss	2023-03-29 12:51:52.583434448 +0000
@@ -107,3 +107,3 @@
     --color-checks-line-hover-bg: rgba(99,110,123,0.1);
-    --color-checks-line-selected-bg: rgba(65,132,228,0.15);
+    --color-checks-line-selected-bg: rgba(65,132,228,0.1);
     --color-checks-line-selected-num-text: #2f81f7;
@@ -309,3 +309,3 @@
     --color-accent-muted: rgba(65,132,228,0.4);
-    --color-accent-subtle: rgba(65,132,228,0.15);
+    --color-accent-subtle: rgba(65,132,228,0.1);
     --color-success-fg: #57ab5a;
--- base/dist/scss/colors/_dark_high_contrast.scss	2023-03-29 12:52:55.648499671 +0000
+++ dist/scss/colors/_dark_high_contrast.scss	2023-03-29 12:51:52.587434516 +0000
@@ -107,3 +107,3 @@
     --color-checks-line-hover-bg: rgba(158,167,179,0.1);
-    --color-checks-line-selected-bg: rgba(64,158,255,0.15);
+    --color-checks-line-selected-bg: rgba(64,158,255,0.1);
     --color-checks-line-selected-num-text: #2f81f7;
@@ -309,3 +309,3 @@
     --color-accent-muted: #409eff;
-    --color-accent-subtle: rgba(64,158,255,0.15);
+    --color-accent-subtle: rgba(64,158,255,0.1);
     --color-success-fg: #26cd4d;
--- base/dist/scss/colors/_dark_tritanopia.scss	2023-03-29 12:52:55.656499806 +0000
+++ dist/scss/colors/_dark_tritanopia.scss	2023-03-29 12:51:52.595434653 +0000
@@ -107,3 +107,3 @@
     --color-checks-line-hover-bg: rgba(110,118,129,0.1);
-    --color-checks-line-selected-bg: rgba(56,139,253,0.15);
+    --color-checks-line-selected-bg: rgba(56,139,253,0.1);
     --color-checks-line-selected-num-text: #2f81f7;
@@ -309,3 +309,3 @@
     --color-accent-muted: rgba(56,139,253,0.4);
-    --color-accent-subtle: rgba(56,139,253,0.15);
+    --color-accent-subtle: rgba(56,139,253,0.1);
     --color-success-fg: #58a6ff;
--- base/dist/scss/colors/_light.scss	2023-03-29 12:52:55.520497502 +0000
+++ dist/scss/colors/_light.scss	2023-03-29 12:51:52.547433833 +0000
@@ -260,3 +260,3 @@
     --color-action-list-item-danger-active-bg: #ffebe9;
-    --color-action-list-item-danger-hover-text: #cf222e;
+    --color-action-list-item-danger-hover-text: #d1242f;
     --color-switch-track-bg: #eaeef2;
@@ -315,3 +315,3 @@
     --color-attention-fg: #9a6700;
-    --color-attention-emphasis: #bf8700;
+    --color-attention-emphasis: #9a6700;
     --color-attention-muted: rgba(212,167,44,0.4);
@@ -322,3 +322,3 @@
     --color-severe-subtle: #fff1e5;
-    --color-danger-fg: #cf222e;
+    --color-danger-fg: #d1242f;
     --color-danger-emphasis: #cf222e;
@@ -330,3 +330,3 @@
     --color-open-subtle: #dafbe1;
-    --color-closed-fg: #cf222e;
+    --color-closed-fg: #d1242f;
     --color-closed-emphasis: #cf222e;
--- base/dist/scss/colors/_light_colorblind.scss	2023-03-29 12:52:55.600498858 +0000
+++ dist/scss/colors/_light_colorblind.scss	2023-03-29 12:51:52.567434175 +0000
@@ -260,3 +260,3 @@
     --color-action-list-item-danger-active-bg: #fff5e8;
-    --color-action-list-item-danger-hover-text: #b35900;
+    --color-action-list-item-danger-hover-text: #d1242f;
     --color-switch-track-bg: #eaeef2;
@@ -315,3 +315,3 @@
     --color-attention-fg: #9a6700;
-    --color-attention-emphasis: #bf8700;
+    --color-attention-emphasis: #9a6700;
     --color-attention-muted: rgba(212,167,44,0.4);
@@ -322,3 +322,3 @@
     --color-severe-subtle: #fff5e8;
-    --color-danger-fg: #b35900;
+    --color-danger-fg: #d1242f;
     --color-danger-emphasis: #b35900;
--- base/dist/scss/colors/_light_high_contrast.scss	2023-03-29 12:52:55.560498180 +0000
+++ dist/scss/colors/_light_high_contrast.scss	2023-03-29 12:51:52.563434106 +0000
@@ -322,3 +322,3 @@
     --color-severe-subtle: #fff2d5;
-    --color-danger-fg: #a0111f;
+    --color-danger-fg: #d1242f;
     --color-danger-emphasis: #a0111f;
@@ -330,3 +330,3 @@
     --color-open-subtle: #d2fedb;
-    --color-closed-fg: #a0111f;
+    --color-closed-fg: #d1242f;
     --color-closed-emphasis: #a0111f;
--- base/dist/scss/colors/_light_tritanopia.scss	2023-03-29 12:52:55.616499129 +0000
+++ dist/scss/colors/_light_tritanopia.scss	2023-03-29 12:51:52.575434311 +0000
@@ -260,3 +260,3 @@
     --color-action-list-item-danger-active-bg: #ffebe9;
-    --color-action-list-item-danger-hover-text: #cf222e;
+    --color-action-list-item-danger-hover-text: #d1242f;
     --color-switch-track-bg: #eaeef2;
@@ -315,3 +315,3 @@
     --color-attention-fg: #9a6700;
-    --color-attention-emphasis: #bf8700;
+    --color-attention-emphasis: #9a6700;
     --color-attention-muted: rgba(212,167,44,0.4);
@@ -322,3 +322,3 @@
     --color-severe-subtle: #ffebe9;
-    --color-danger-fg: #cf222e;
+    --color-danger-fg: #d1242f;
     --color-danger-emphasis: #cf222e;

@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2023

🟢 No design token changes found

@lukasoppermann lukasoppermann temporarily deployed to github-pages March 29, 2023 12:31 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview March 29, 2023 12:31 Inactive
@lukasoppermann lukasoppermann requested review from simurai and removed request for rezrah and JoshBowdenConcepts March 29, 2023 12:35
@github-actions github-actions bot temporarily deployed to storybook-preview March 29, 2023 12:52 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview March 29, 2023 12:56 Inactive
@lukasoppermann lukasoppermann merged commit 9df92a7 into main Mar 29, 2023
@lukasoppermann lukasoppermann deleted the a11y-follow-up branch March 29, 2023 13:00
@primer-css primer-css mentioned this pull request Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants