Skip to content

Commit

Permalink
Merge branch 'main' of github.com:primer/react into fix/update-blanks…
Browse files Browse the repository at this point in the history
…late-styles
  • Loading branch information
joshblack committed Jul 25, 2024
2 parents 40f9bdd + 801ca96 commit 9a3040c
Show file tree
Hide file tree
Showing 333 changed files with 4,549 additions and 1,013 deletions.
5 changes: 5 additions & 0 deletions .changeset/curvy-shrimps-agree.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

Prevents inactive indicator icon/tooltip from appearing in ActionMenu items
5 changes: 0 additions & 5 deletions .changeset/five-humans-retire.md

This file was deleted.

5 changes: 5 additions & 0 deletions .changeset/lazy-jobs-pump.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": minor
---

Add `loading` state to `Button` and `IconButton`
5 changes: 5 additions & 0 deletions .changeset/modern-carrots-check.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

TextInput: Refactor TextInputInnerAction to use the default icon button tooltip (No changes in the behaviour or DOM is expected)
5 changes: 5 additions & 0 deletions .changeset/nice-forks-joke.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": minor
---

PageHeader: Promote the component to Beta status and now it is available to import from "@primer/react"
5 changes: 5 additions & 0 deletions .changeset/real-bees-vanish.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

experimental/SelectPanel v2: Fix heading color for dark themes
5 changes: 0 additions & 5 deletions .changeset/seven-cherries-serve.md

This file was deleted.

5 changes: 5 additions & 0 deletions .changeset/sixty-trains-flow.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

AnchoredOverlay: Add 'className' prop to the component
5 changes: 5 additions & 0 deletions .changeset/slow-rivers-know.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

PageHeader: Fix shrinking Actions sub component in Safari
5 changes: 5 additions & 0 deletions .changeset/thick-ants-try.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': minor
---

Add experimental ScrollableRegion component and useOverflow hook
5 changes: 0 additions & 5 deletions .changeset/thick-jars-count.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/two-hotels-attend.md

This file was deleted.

5 changes: 5 additions & 0 deletions .changeset/wild-actors-jam.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

StateLabel: Differentiate issue and pull request labels for screen readers
23 changes: 23 additions & 0 deletions .github/workflows/add_staff_label.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Add Staff Label

on:
issues:
types: [opened, reopened]
pull_request:
types: [opened, reopened]

jobs:
add-staff-label:
if: ${{ github.repository == 'primer/react' }}
runs-on: ubuntu-latest
env:
GH_TOKEN: ${{ github.token }}
steps:
- name: Add label to issue
if: ${{ github.event.issue.author_association == 'MEMBER' }}
run: |
gh issue edit ${{github.event.issue.html_url}} --add-label staff
- name: Add label to pull_request
if: ${{ github.event.pull_request.author_association == 'MEMBER' }}
run: |
gh pr edit ${{github.event.pull_request.html_url}} --add-label staff
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
20 changes: 20 additions & 0 deletions contributor-docs/adrs/adr-000-template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# Title

## Status

| Stage | Status |
| -------- | ----------- |
| Approved | <!----> |
| Adopted | <!-- 🚧 --> |

## Context

<!-- Provide background information needed for this ADR -->

## Decision

<!-- Provide information about the decision made by this ADR -->

### Impact

<!-- Describe the impact of the decision -->
2 changes: 1 addition & 1 deletion contributor-docs/adrs/adr-001-typescript.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# ADR 1: TypeScript
# TypeScript

## Status

Expand Down
2 changes: 1 addition & 1 deletion contributor-docs/adrs/adr-002-behavior-isolation.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# ADR 2: Isolating behaviors through custom clements and vanilla JavaScript
# Isolating behaviors through custom clements and vanilla JavaScript

## Status

Expand Down
2 changes: 1 addition & 1 deletion contributor-docs/adrs/adr-003-prop-norms.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# ADR 003: Prop norms in Primer React Components
# Prop norms in Primer React Components

## Status

Expand Down
2 changes: 1 addition & 1 deletion contributor-docs/adrs/adr-004-children-as-api.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# ADR 004: Strict props or Composite components
# Strict props or Composite components

## Status

Expand Down
2 changes: 1 addition & 1 deletion contributor-docs/adrs/adr-005-box-sx.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# ADR 005: Use Box as a building block for all other components
# Use Box as a building block for all other components

## Status

Expand Down
2 changes: 1 addition & 1 deletion contributor-docs/adrs/adr-006-drafts.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# ADR 6: Parallel experimental track & plan for deprecated components
# Parallel experimental track & plan for deprecated components

## Status

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# ADR 008: Lowering the barrier to entry for experimental components
# Lowering the barrier to entry for experimental components

## Status

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# ADR 009: Use Interaction testing in storybook to maintain components
# Use Interaction testing in storybook to maintain components

> **Warning**
> This ADR is superceded by [`ADR 018`](./adr-018-interaction-tests-revisited.md)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# ADR 010: Isolating behaviors through custom elements and vanilla JavaScript
# Isolating behaviors through custom elements and vanilla JavaScript

## Status

Expand Down
2 changes: 1 addition & 1 deletion contributor-docs/adrs/adr-010-drafts-are-experimental.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# ADR 010: Merge drafts status into experimental
# Merge drafts status into experimental

## Status

Expand Down
2 changes: 1 addition & 1 deletion contributor-docs/adrs/adr-011-snapshot-tests.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# ADR 011: Snapshot tests
# Snapshot tests

## Status

Expand Down
2 changes: 1 addition & 1 deletion contributor-docs/adrs/adr-012-development-warnings.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# ADR 012: Development Warnings
# Development Warnings

## Status

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# ADR 12: File structure
# File structure

## Status

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# ADR 015: NPM Workspaces
# NPM Workspaces

## Status

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# ADR 016: Internal Modules
# Internal Modules

## Status

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# ADR 17: Styling with CSS
# Styling with CSS

## Status

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# ADR 018: Interaction testing (revisited)
# Interaction testing (revisited)

## Status

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# ADR 019: Responsive Values
# Responsive Values

## Status

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# ADR 020: Deprecating Props
# Deprecating Props

## Status

Expand Down
2 changes: 1 addition & 1 deletion contributor-docs/adrs/adr-020-live-regions.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# ADR 020: Live Regions
# Live Regions

## Status

Expand Down
1 change: 1 addition & 0 deletions docs/content/drafts/DataTable.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
title: DataTable
componentId: data_table
status: Draft
a11yReviewed: true
---

import data from '../../../packages/react/src/DataTable/DataTable.docs.json'
Expand Down
58 changes: 58 additions & 0 deletions e2e/components/ActionList.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -515,6 +515,36 @@ test.describe('ActionList', () => {
}
})

test.describe('Loading Item', () => {
for (const theme of themes) {
test.describe(theme, () => {
test('default @vrt', async ({page}) => {
await visit(page, {
id: 'components-actionlist-features--loading-item',
globals: {
colorScheme: theme,
},
})

// Default state
expect(await page.screenshot({animations: 'disabled'})).toMatchSnapshot(
`ActionList.Loading Item.${theme}.png`,
)
})

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'components-actionlist-features--loading-item',
globals: {
colorScheme: theme,
},
})
await expect(page).toHaveNoViolations()
})
})
}
})

test.describe('Group With Filled Title', () => {
for (const theme of themes) {
test.describe(theme, () => {
Expand Down Expand Up @@ -654,4 +684,32 @@ test.describe('ActionList', () => {
})
}
})

test.describe('Full Variant', () => {
for (const theme of themes) {
test.describe(theme, () => {
test('default @vrt', async ({page}) => {
await visit(page, {
id: 'components-actionlist-features--full-variant',
globals: {
colorScheme: theme,
},
})

// Default state
expect(await page.screenshot()).toMatchSnapshot(`ActionList.Full Variant.${theme}.png`)
})

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'components-actionlist-features--full-variant',
globals: {
colorScheme: theme,
},
})
await expect(page).toHaveNoViolations()
})
})
}
})
})
30 changes: 30 additions & 0 deletions e2e/components/ActionMenu.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,36 @@ test.describe('ActionMenu', () => {
}
})

test.describe('Loading Items', () => {
for (const theme of themes) {
test.describe(theme, () => {
test('default @vrt', async ({page}) => {
await visit(page, {
id: 'components-actionmenu-features--loading-items',
globals: {
colorScheme: theme,
},
})

// Open menu
await page.locator('button', {hasText: 'Open menu'}).waitFor()
await page.getByRole('button', {name: 'Open menu'}).click()
expect(await page.screenshot({animations: 'disabled'})).toMatchSnapshot()
})

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'components-actionmenu-features--loading-items',
globals: {
colorScheme: theme,
},
})
await expect(page).toHaveNoViolations()
})
})
}
})

test.describe('Multi Select', () => {
for (const theme of themes) {
test.describe(theme, () => {
Expand Down
Loading

0 comments on commit 9a3040c

Please sign in to comment.