-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor internal components into internal
folder
#3230
Comments
Thanks for filing @joshblack! Should this issue go into our Primer teams backlog "inbox" for triage by the team, or did you have other plans for it? |
Hey @lesliecdubs! No plans in particular, just was something that came up in PR reviews last week. Inbox triage could be a great place for it 👍 |
_VisuallyHidden.tsx is still on the page https://github.com/primer/react/tree/main/src, so it should not be checked off, but _TextInputInnerVisualSlot should be. |
It appears there are two |
We shouldn't have two - we should just have one. @joshblack - does your |
It looks like the same thing also may be happening with _TextInputInnerAction.tsx |
@mperrotti I think they have a difference in API and styles and we just haven't taken the time to merge them yet. I think the difference at that point ends up being that you would toggle rendering |
This is a follow-up to our ADR on Internal Modules. This issues captures the remaining internal components or helpers that we should consider migrating into
src/internal
to prevent being imported outside of the package.The text was updated successfully, but these errors were encountered: