Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3230 Refactor internal components - ValidationAnimationContainer #3377

Conversation

green6erry
Copy link
Contributor

@green6erry green6erry commented Jun 5, 2023

This is part of the refactor per ADR https://github.com/primer/react/blob/main/contributor-docs/adrs/adr-016-internal-modules.md

Closes part of #3230 (type the issue number after # if applicable; otherwise remove this line)

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Changes are SSR compatible
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@green6erry green6erry requested a review from a team June 5, 2023 21:37
@green6erry green6erry linked an issue Jun 5, 2023 that may be closed by this pull request
12 tasks
@green6erry green6erry requested a review from mperrotti June 5, 2023 21:37
@changeset-bot
Copy link

changeset-bot bot commented Jun 5, 2023

⚠️ No Changeset found

Latest commit: 69d2400

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@green6erry green6erry added the skip changeset This change does not need a changelog label Jun 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 101.66 KB (-0.01% 🔽)
dist/browser.umd.js 102.23 KB (-0.01% 🔽)

@green6erry green6erry added this pull request to the merge queue Jun 6, 2023
Merged via the queue into main with commit cbc1ab8 Jun 6, 2023
@green6erry green6erry deleted the 3230-refactor-internal-components-ValidationAnimationContainer branch June 6, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor internal components into internal folder
2 participants