-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Q3 Wildflower Tracking PR #283
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Colocate Primer CSS global injections with components that need them
Use @svgr/webpack to inline SVG as React components
Remove MergeStatus and unused demo stuff
Adding active style to side nav links
Standardize asset path prefix
Making docs pages responsive
fix scale command
shawnbot
reviewed
Sep 28, 2018
"postdist": "npm run dist:css", | ||
"dist:css": "node-sass --include-path node_modules --output-style compressed src/primer-components.scss -o dist", | ||
"prepack": "script/npm-pack-check", | ||
"postdist": "du -ha dist", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, this is not necessary but might just be handy for comparing our bundle sizes between releases.
Updating component docs descriptions
DonutChart → Donut, DonutSlice → Donut.Slice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes here.
❌ Breaking Changes ❌
scheme
ormuted
props. Style the color of the link text usingcolor
instead. The Link also now has no underline by default. Addunderline
to override this. Link updates #282Donut
andDonut.Slice
DonutChart → Donut, DonutSlice → Donut.Slice #269🚀 New features
<BaseStyles>
component for establishing typographic styles Add BaseStyles component, inject global CSS #276📝 Documentation
🐛 Bug fixes
If development process was changed
The Styling section of our readme has been updated to reflect the CSS changes in #276.
Merge checklist