Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PageHeader: A11y eng review remediations #2900

Merged
merged 9 commits into from
Feb 16, 2023
Merged

Conversation

broccolinisoup
Copy link
Member

@broccolinisoup broccolinisoup commented Feb 13, 2023

Describe your changes here.

This PR addresses issues found and implement recommendations from PageHeader accessibility eng review . Please see this comment for more info on each item below.

Issues addressed:

  • Remove default value of aria-label on ParentLink component.

Recommendations implemented:

  • Allow usage of as=”nav | div” on PageHeader.Navigation component.

Also Added a feature story to cover custom components that can be passed to PageHeader.Navigation as children

Screenshots

No visual changes.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2023

🦋 Changeset detected

Latest commit: 2347578

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 89.74 KB (0%)
dist/browser.umd.js 90.28 KB (0%)

@broccolinisoup broccolinisoup temporarily deployed to github-pages February 13, 2023 05:59 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2900 February 13, 2023 06:00 Inactive
@broccolinisoup broccolinisoup temporarily deployed to github-pages February 13, 2023 06:46 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2900 February 13, 2023 06:46 Inactive
@broccolinisoup broccolinisoup changed the title A11y page header PageHeader: A11y eng review remediations Feb 13, 2023
@broccolinisoup broccolinisoup temporarily deployed to github-pages February 13, 2023 06:54 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2900 February 13, 2023 06:54 Inactive
@broccolinisoup broccolinisoup temporarily deployed to github-pages February 13, 2023 08:00 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2900 February 13, 2023 08:00 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2900 February 13, 2023 08:10 Inactive
@primer primer bot temporarily deployed to github-pages February 13, 2023 08:11 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2900 February 13, 2023 08:12 Inactive
@broccolinisoup broccolinisoup marked this pull request as ready for review February 13, 2023 09:02
Copy link
Contributor

@TylerJDev TylerJDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Love the additional tests added too. 🎉

Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment for wrapping the warning in a __DEV__ check, should be good to go after that!

src/PageHeader/PageHeader.tsx Outdated Show resolved Hide resolved
@broccolinisoup broccolinisoup temporarily deployed to github-pages February 15, 2023 05:26 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2900 February 15, 2023 05:26 Inactive
@broccolinisoup broccolinisoup temporarily deployed to github-pages February 15, 2023 23:34 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2900 February 15, 2023 23:35 Inactive
@broccolinisoup broccolinisoup temporarily deployed to github-pages February 16, 2023 04:37 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2900 February 16, 2023 04:37 Inactive
@broccolinisoup broccolinisoup temporarily deployed to github-pages February 16, 2023 05:31 — with GitHub Actions Inactive
@broccolinisoup broccolinisoup added this pull request to the merge queue Feb 16, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 16, 2023
@broccolinisoup broccolinisoup added this pull request to the merge queue Feb 16, 2023
Merged via the queue into main with commit 3768cd7 Feb 16, 2023
@broccolinisoup broccolinisoup deleted the a11y-page-header branch February 16, 2023 09:17
@primer-css primer-css mentioned this pull request Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants