Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease invisible button icon CSS specifity #2925

Merged
merged 6 commits into from
Feb 22, 2023
Merged

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Feb 21, 2023

This fixes the ability to override the invisible button's icon color with sx

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2023

🦋 Changeset detected

Latest commit: e7e0e4c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 94.58 KB (+0.03% 🔺)
dist/browser.umd.js 95.15 KB (+0.02% 🔺)

Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@langermank langermank temporarily deployed to github-pages February 21, 2023 23:36 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2925 February 21, 2023 23:36 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2925 February 21, 2023 23:37 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2925 February 21, 2023 23:40 Inactive
@langermank langermank temporarily deployed to github-pages February 21, 2023 23:46 — with GitHub Actions Inactive
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@colebemis colebemis added this pull request to the merge queue Feb 21, 2023
Merged via the queue into main with commit 6f50b15 Feb 22, 2023
@colebemis colebemis deleted the invisible-button-bug branch February 22, 2023 00:07
@primer-css primer-css mentioned this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants