-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(DataTable): add Table.Skeleton #3055
Conversation
🦋 Changeset detectedLatest commit: 0ebec96 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
…o feat/add-table-skeleton
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🚀
- Verify that the "With Loading" example is available on the storybook and included in the docs.json for DataTable
- Verify that the styles look as expected for the Table Skeleton
- Verify that Table.Skeleton is defined and its props are exported
- Verify that a test exists for rendering a Table.Skeleton
bump @mperrotti when you have a sec to review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm so sorry I didn't review this sooner! I have no idea how it slipped by me.
flex-direction: column; | ||
} | ||
|
||
.TableCellSkeletonItem { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we see this style of "loading" placeholder come up again, we should consider creating some kind of "SkeletonLoader" component that can be reused. We already use something identical in TreeView.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mperrotti agreed 100% 💯 Would be so useful
Batch: https://github.com/github/primer/issues/1892
This is currently a visual an API implementation of
Table.Skeleton
. The behavior is not finalized when it comes to how to indicate loading content. In the meantime, the cells themselves contain "Loading" as text content. Most of the styles for the Table cell skeleton items are lifted from TreeView.One caveat to this API, it is currently bound to
Column
as it seemed natural to toggle between the two with an existing set ofcolumns
. It may be useful in the future to permit less restrictive types (likeArray<string>
) for usage.Testing & Reviewing
Table.Skeleton
is defined and its props are exportedTable.Skeleton
rows
since it's a visual only change and I did not want to test structural changes in enzyme