Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SSR-compatible slot implementation in MarkdownEditor #3174

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

colebemis
Copy link
Contributor

Swaps out the underlying slots implementation for MarkdownEditor.

See #1690 for more context.

@colebemis colebemis requested review from a team and mperrotti April 14, 2023 22:35
@changeset-bot
Copy link

changeset-bot bot commented Apr 14, 2023

🦋 Changeset detected

Latest commit: 7c4affb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 95.88 KB (0%)
dist/browser.umd.js 96.48 KB (0%)

@colebemis colebemis added this pull request to the merge queue Apr 20, 2023
Merged via the queue into main with commit d4c6ae5 Apr 20, 2023
@colebemis colebemis deleted the markdowneditor-slots branch April 20, 2023 22:56
@primer-css primer-css mentioned this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants