Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor FilteredActionList to address a11y violations and use new ActionList. #3247

Merged
merged 53 commits into from
May 26, 2023
Merged

Refactor FilteredActionList to address a11y violations and use new ActionList. #3247

merged 53 commits into from
May 26, 2023

Commits on Apr 27, 2023

  1. Update FilteredActionList to use non-deprecated ActionList.

    @radglob
    radglob committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    127b7a6 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2023

  1. Merge branch 'main' of github.com:primer/react into refactor-filtered… 

    …-action-list
    @radglob
    radglob committed May 1, 2023
    Configuration menu
    Copy the full SHA
    353465d View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. Use non-deprecated ActionList in FilteredActionList.

    @radglob
    radglob committed May 3, 2023
    Configuration menu
    Copy the full SHA
    0ee48c6 View commit details
    Browse the repository at this point in the history

  2. Fix a11y issues in FilteredActionList story.

    @radglob
    radglob committed May 3, 2023
    Configuration menu
    Copy the full SHA
    5558264 View commit details
    Browse the repository at this point in the history

  3. Add prop to hide selection component if needed.

    @radglob
    radglob committed May 3, 2023
    Configuration menu
    Copy the full SHA
    4525416 View commit details
    Browse the repository at this point in the history

  4. Remove unused hook import.

    @radglob
    radglob committed May 3, 2023
    Configuration menu
    Copy the full SHA
    f67e7db View commit details
    Browse the repository at this point in the history

  5. Get SavedReplies to look as it did with deprecated ActionList.

    @radglob
    radglob committed May 3, 2023
    Configuration menu
    Copy the full SHA
    c7e1ffd View commit details
    Browse the repository at this point in the history

  6. Fix failing test.

    @radglob
    radglob committed May 3, 2023
    Configuration menu
    Copy the full SHA
    b4238fb View commit details
    Browse the repository at this point in the history

  7. Create weak-jokes-chew.md

    @radglob
    radglob authored May 3, 2023
    Configuration menu
    Copy the full SHA
    40a08b5 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into refactor-filtered-action-list

    @radglob
    radglob authored May 3, 2023
    Configuration menu
    Copy the full SHA
    0ec32c1 View commit details
    Browse the repository at this point in the history

  9. Update generated/components.json

    @radglob @github-actions
    radglob authored and github-actions[bot] committed May 3, 2023
    Configuration menu
    Copy the full SHA
    6f4fc14 View commit details
    Browse the repository at this point in the history

  10. Fix themePreval snapshot.

    @radglob
    radglob committed May 3, 2023
    Configuration menu
    Copy the full SHA
    adefbbe View commit details
    Browse the repository at this point in the history

  11. Linting fixes.

    @radglob
    radglob committed May 3, 2023
    Configuration menu
    Copy the full SHA
    30839b0 View commit details
    Browse the repository at this point in the history

  12. Fix type-check errors.

    @radglob
    radglob committed May 3, 2023
    Configuration menu
    Copy the full SHA
    6fb05d0 View commit details
    Browse the repository at this point in the history

  13. Update themePreval snapshot again.

    @radglob
    radglob committed May 3, 2023
    Configuration menu
    Copy the full SHA
    470e250 View commit details
    Browse the repository at this point in the history

  14. Fix themePreval snapshot to match origin. Unsure why it's not generat… 

    …ing the same way.
    @radglob
    radglob committed May 3, 2023
    Configuration menu
    Copy the full SHA
    3da704f View commit details
    Browse the repository at this point in the history

  15. Hide selections in MarkdownEditor saved replies.

    @radglob
    radglob committed May 3, 2023
    Configuration menu
    Copy the full SHA
    069e747 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2023

  1. Merge branch 'main' into refactor-filtered-action-list

    @radglob
    radglob authored May 8, 2023
    Configuration menu
    Copy the full SHA
    b152869 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into refactor-filtered-action-list

    @radglob
    radglob authored May 8, 2023
    Configuration menu
    Copy the full SHA
    82ba413 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into refactor-filtered-action-list

    @radglob
    radglob authored May 8, 2023
    Configuration menu
    Copy the full SHA
    1232337 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. Merge branch 'main' into refactor-filtered-action-list

    @radglob
    radglob authored May 9, 2023
    Configuration menu
    Copy the full SHA
    bd3ce03 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into refactor-filtered-action-list

    @radglob
    radglob authored May 9, 2023
    Configuration menu
    Copy the full SHA
    4f7f4d0 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into refactor-filtered-action-list

    @radglob
    radglob authored May 9, 2023
    Configuration menu
    Copy the full SHA
    dd6f3f6 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. Merge branch 'main' into refactor-filtered-action-list

    @radglob
    radglob authored May 10, 2023
    Configuration menu
    Copy the full SHA
    542240b View commit details
    Browse the repository at this point in the history

  2. Remove hideSelection prop and add defaultRenderFn to FilteredActionLi… 

    …st so these don't have to be defined manually everywhere.
    @radglob
    radglob committed May 10, 2023
    Configuration menu
    Copy the full SHA
    19b3674 View commit details
    Browse the repository at this point in the history

  3. Fix selection rendering (needed explicit selected boolean) and fix Se… 

    …lectPanel docs.
    @radglob
    radglob committed May 10, 2023
    Configuration menu
    Copy the full SHA
    dc8b1bb View commit details
    Browse the repository at this point in the history

  4. Pass selectionVariant illegally to SelectPanel in src/MarkdownEditor/… 

    …_SavedReplies.tsx so Selection components don't render.
    @radglob
    radglob committed May 10, 2023
    Configuration menu
    Copy the full SHA
    61694c6 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. Merge branch 'main' into refactor-filtered-action-list

    @radglob
    radglob authored May 11, 2023
    Configuration menu
    Copy the full SHA
    ca4bfc3 View commit details
    Browse the repository at this point in the history

  2. Remove remaining references of hideSelection prop.

    @radglob
    radglob committed May 11, 2023
    Configuration menu
    Copy the full SHA
    99281c2 View commit details
    Browse the repository at this point in the history

  3. Update changeset to reflect that changes impact SelectPanel.

    @radglob
    radglob committed May 11, 2023
    Configuration menu
    Copy the full SHA
    83bdd99 View commit details
    Browse the repository at this point in the history

  4. Remove renderFn prop from SelectPanel and use default for FilteredAct… 

    …ionList, which seems to cover most cases.
    @radglob
    radglob committed May 11, 2023
    Configuration menu
    Copy the full SHA
    2021aab View commit details
    Browse the repository at this point in the history

  5. Fix truncation in SavedReplies descriptions.

    @radglob
    radglob committed May 11, 2023
    Configuration menu
    Copy the full SHA
    dca5ee7 View commit details
    Browse the repository at this point in the history

  6. Update generated/components.json

    @radglob @github-actions
    radglob authored and github-actions[bot] committed May 11, 2023
    Configuration menu
    Copy the full SHA
    936b08c View commit details
    Browse the repository at this point in the history

  7. Fix linting error.

    @radglob
    radglob committed May 11, 2023
    Configuration menu
    Copy the full SHA
    626efc4 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. Don't make renderFn a prop (if we need to make this configurable, we … 

    …can expose it later. Use maxWidth 100% for SavedReplies truncation.
    @radglob
    radglob committed May 12, 2023
    Configuration menu
    Copy the full SHA
    47968e0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into refactor-filtered-action-list

    @radglob
    radglob authored May 12, 2023
    Configuration menu
    Copy the full SHA
    c6f65b9 View commit details
    Browse the repository at this point in the history

  3. Use showDividers prop in SelectPanel story.

    @radglob
    radglob committed May 12, 2023
    Configuration menu
    Copy the full SHA
    13e256b View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. Merge branch 'main' into refactor-filtered-action-list

    @radglob
    radglob authored May 15, 2023
    Configuration menu
    Copy the full SHA
    de41c26 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into refactor-filtered-action-list

    @radglob
    radglob authored May 15, 2023
    Configuration menu
    Copy the full SHA
    15bf1a4 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into refactor-filtered-action-list

    @radglob
    radglob authored May 15, 2023
    Configuration menu
    Copy the full SHA
    a1897a6 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. Merge branch 'main' into refactor-filtered-action-list

    @radglob
    radglob authored May 16, 2023
    Configuration menu
    Copy the full SHA
    616d3a3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into refactor-filtered-action-list

    @radglob
    radglob authored May 16, 2023
    Configuration menu
    Copy the full SHA
    90e395e View commit details
    Browse the repository at this point in the history

  3. Formatting.

    @radglob
    radglob committed May 16, 2023
    Configuration menu
    Copy the full SHA
    e3edf33 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. Merge branch 'main' into refactor-filtered-action-list

    @radglob
    radglob authored May 17, 2023
    Configuration menu
    Copy the full SHA
    431bce9 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2023

  1. Merge branch 'main' into refactor-filtered-action-list

    @radglob
    radglob authored May 19, 2023
    Configuration menu
    Copy the full SHA
    bd076ec View commit details
    Browse the repository at this point in the history

Commits on May 22, 2023

  1. Merge branch 'main' into refactor-filtered-action-list

    @radglob
    radglob authored May 22, 2023
    Configuration menu
    Copy the full SHA
    1e2b1a9 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. Add temporary support for showItemDividers prop to SelectPanel to kee… 

    …p backwards compatibility.
    @radglob
    radglob committed May 23, 2023
    Configuration menu
    Copy the full SHA
    c361650 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into refactor-filtered-action-list

    @radglob
    radglob authored May 23, 2023
    Configuration menu
    Copy the full SHA
    059b825 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into refactor-filtered-action-list

    @radglob
    radglob authored May 23, 2023
    Configuration menu
    Copy the full SHA
    a66b7cd View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. Merge branch 'main' of github.com:primer/react into refactor-filtered… 

    …-action-list
    @radglob
    radglob committed May 25, 2023
    Configuration menu
    Copy the full SHA
    09ce036 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into refactor-filtered-action-list

    @radglob
    radglob authored May 25, 2023
    Configuration menu
    Copy the full SHA
    80ccbef View commit details
    Browse the repository at this point in the history

  3. Support passing deprecated showItemDividers prop in ActionList.

    @radglob
    radglob committed May 25, 2023
    Configuration menu
    Copy the full SHA
    794faf4 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. Merge branch 'main' into refactor-filtered-action-list

    @radglob
    radglob authored May 26, 2023
    Configuration menu
    Copy the full SHA
    4740613 View commit details
    Browse the repository at this point in the history