-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds contrast property to textArea component #3484
adds contrast property to textArea component #3484
Conversation
🦋 Changeset detectedLatest commit: 61d9b02 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This comment was marked as duplicate.
This comment was marked as duplicate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ValbertMartins 👋🏻 Thanks for the PR! We usually need an issue for these type of PRs that introduces feature requests to be able to access it from an accessibility, usability etc point of view. Would you mind creating an issue so that we can discuss it as a team?
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days. |
Sorry this got closed as stale, we just re-triaged the issue #3487 related to this PR and think this is still valid. Reopening and requesting review from maintainers 🔄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @ValbertMartins 👋🏻 Thanks so much for pushing this PR! Could you please add a changeset for the changes we are introducing here? You can find the instructions in our contributing documentation - Please let me know if you have any questions 🙌🏻
Co-authored-by: Armağan <broccolinisoup@github.com>
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days. |
@broccolinisoup would you be willing to take over this PR to add in a changeset so we can get this merged, unless there's more outstanding to do? @ValbertMartins you are welcome to make this change ^ as well, just didn't want to let this PR stagnate again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🚀 Just added the changeset file, thanks so much for raising this PR.
Thanks @lesliecdubs for bringing this PR to my attention! I added the changeset file, and reviewed the PR. All looks great. @ValbertMartins I'm going to merge it now, thanks for your contribution and sorry for the delay! 🙏🏻 |
Describe your changes here.
• add contrast property to textarea component (same property existent in textInput component)
Screenshots
• textarea with contrast
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.