Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds contrast property to textArea component #3484

Merged
merged 5 commits into from
Nov 22, 2023

Conversation

ValbertMartins
Copy link
Contributor

@ValbertMartins ValbertMartins commented Jul 5, 2023

Describe your changes here.

• add contrast property to textarea component (same property existent in textInput component)

Screenshots

• textarea with contrast
Captura de tela 2023-07-04 195205

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Changes are SSR compatible
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@ValbertMartins ValbertMartins requested review from a team and mperrotti July 5, 2023 00:34
@changeset-bot
Copy link

changeset-bot bot commented Jul 5, 2023

🦋 Changeset detected

Latest commit: 61d9b02

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ValbertMartins ValbertMartins changed the title adds a contrast property to textarea component adds contrast property to textArea component Jul 5, 2023
@ValbertMartins ValbertMartins temporarily deployed to github-pages July 5, 2023 00:40 — with GitHub Actions Inactive
@broccolinisoup

This comment was marked as duplicate.

Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ValbertMartins 👋🏻 Thanks for the PR! We usually need an issue for these type of PRs that introduces feature requests to be able to access it from an accessibility, usability etc point of view. Would you mind creating an issue so that we can discuss it as a team?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2023

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 3, 2023
@github-actions github-actions bot closed this Sep 10, 2023
@lesliecdubs
Copy link
Member

Sorry this got closed as stale, we just re-triaged the issue #3487 related to this PR and think this is still valid. Reopening and requesting review from maintainers 🔄

@lesliecdubs lesliecdubs reopened this Sep 11, 2023
@lesliecdubs lesliecdubs temporarily deployed to github-pages September 11, 2023 21:52 — with GitHub Actions Inactive
@github-actions github-actions bot removed the Stale label Sep 11, 2023
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ValbertMartins 👋🏻 Thanks so much for pushing this PR! Could you please add a changeset for the changes we are introducing here? You can find the instructions in our contributing documentation - Please let me know if you have any questions 🙌🏻

src/Textarea/Textarea.tsx Outdated Show resolved Hide resolved
Co-authored-by: Armağan <broccolinisoup@github.com>
Copy link
Contributor

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 22, 2023
@lesliecdubs
Copy link
Member

@broccolinisoup would you be willing to take over this PR to add in a changeset so we can get this merged, unless there's more outstanding to do?

@ValbertMartins you are welcome to make this change ^ as well, just didn't want to let this PR stagnate again!

@github-actions github-actions bot removed the Stale label Nov 22, 2023
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀 Just added the changeset file, thanks so much for raising this PR.

@broccolinisoup
Copy link
Member

Thanks @lesliecdubs for bringing this PR to my attention! I added the changeset file, and reviewed the PR. All looks great.

@ValbertMartins I'm going to merge it now, thanks for your contribution and sorry for the delay! 🙏🏻

@broccolinisoup broccolinisoup added this pull request to the merge queue Nov 22, 2023
Merged via the queue into primer:main with commit e403789 Nov 22, 2023
28 checks passed
@primer primer bot mentioned this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants