Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move title tag to App #352

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Move title tag to App #352

merged 1 commit into from
Nov 7, 2018

Conversation

matallo
Copy link
Contributor

@matallo matallo commented Nov 7, 2018

closes #351

  • Moved the title from pages/_document.js to pages/_app.js

@vercel
Copy link

vercel bot commented Nov 7, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

emplums
emplums approved these changes Nov 7, 2018
View reviewed changes
Copy link

@emplums emplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for making a PR! 🙌

@emplums
Copy link

emplums commented Nov 7, 2018 •
edited
Loading

Since this is a docs change and the docs aren't included in the npm package, I'm going to merge this without a release.

@emplums emplums merged commit 05e9ec1 into primer:master Nov 7, 2018
@emplums emplums mentioned this pull request Nov 8, 2018
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emplums emplums emplums approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<title> should not be used in _document.js's <Head>
2 participants
@matallo @emplums