Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update release-schedule workflow with dynamic schedule #3769

Merged
merged 12 commits into from
Sep 27, 2023

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Sep 26, 2023

Closes #3711

Our release schedule workflow currently runs every week and will open and close issues regardless of the settings of the current schedule that we have in PagerDuty. This PR adds in a composite action, pagerduty, that will allow us to get the current and previous schedule from the PagerDuty API and uses it in the release-schedule workflow to accurately open and close issues related to this schedule

Changelog

New

  • Add pagerduty action under .github/actions/pagerduty which outputs schedule information

Changed

  • Update release-schedule workflow to use new pagerduty action and correctly open/close release tracking issues for a given schedule

Removed

Rollout strategy

None

Testing & Reviewing

This is something that likely needs to be tested with workflow_dispatch to see if it's working as-intended. Ran it over in: https://github.com/primer/react/actions/runs/6316114089 with the new "dry" flag to see how it would run. Thankfully it picked up on the fact that we have an existing release issue but it was one that it couldn't identify because of how the ids are changing (now they just use the schedule id)

@joshblack joshblack requested review from a team and siddharthkp September 26, 2023 16:45
@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2023

⚠️ No Changeset found

Latest commit: a8383a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 104.36 KB (0%)
dist/browser.umd.js 104.94 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-3769 September 26, 2023 16:51 Inactive
@joshblack joshblack temporarily deployed to github-pages September 26, 2023 16:53 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3769 September 26, 2023 16:53 Inactive
@joshblack joshblack temporarily deployed to github-pages September 26, 2023 16:59 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3769 September 26, 2023 17:00 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3769 September 26, 2023 17:16 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3769 September 26, 2023 17:19 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3769 September 26, 2023 17:21 Inactive
@joshblack joshblack temporarily deployed to github-pages September 26, 2023 17:28 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3769 September 26, 2023 17:29 Inactive
@joshblack joshblack added the skip changeset This change does not need a changelog label Sep 26, 2023
@joshblack joshblack temporarily deployed to github-pages September 26, 2023 18:28 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3769 September 26, 2023 18:28 Inactive
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Let's try it out!

@github-actions github-actions bot temporarily deployed to storybook-preview-3769 September 27, 2023 15:20 Inactive
@joshblack joshblack added this pull request to the merge queue Sep 27, 2023
Merged via the queue into main with commit 29759cc Sep 27, 2023
30 of 31 checks passed
@joshblack joshblack deleted the ci/add-pagerduty-action branch September 27, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Release Schedule workflow to account for new release cadence
2 participants