[Fix] Non-standard formatted tasklist items are not identified as tasklist items #3972
Conversation
🦋 Changeset detectedLatest commit: 1aad0c1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
| @@ -45,7 +45,7 @@ const isNumericListItem = (item: ListItem | null): item is NumericListItem => ty | |||
| export const parseListItem = (line: string): ListItem | null => { | |||
| const result = listItemRegex.exec(line) | |||
| if (!result) return null | |||
| const [, leadingWhitespace = '', fullDelimeter, itemNumberStr = '', taskBox = null, text] = result | |||
| const [, leadingWhitespace = '', fullDelimeter, itemNumberStr = '', , taskBox = null, text] = result | |||
There was a problem hiding this comment.
Here you are skipping the capture group for the one or two spaces, meaning that the updated Markdown will always have only one space. Do we maybe want to preserve the number of spaces like we do with leadingWhitespace here?
There was a problem hiding this comment.
Addressed in ad9c47f
| @@ -29,7 +29,7 @@ const calculateNextListItemStarter = ({leadingWhitespace = '', delimeter, taskBo | |||
| * 3. Task box (optional) | |||
| * 4. Everything following | |||
| */ | |||
| export const listItemRegex = /^(\s*)([*-]|(\d+)\.)\s(?:(\[[\sx]\])\s)?(.*)/i | |||
| export const listItemRegex = /^(\s*)([*-]|(\d+)\.)(\s{1,2})(?:(\[[\sx]\])\s)?(.*)/i | |||
There was a problem hiding this comment.
Are tab characters valid here? Maybe more correct would be space only ( ). Not sure though. It's a minor thing though since that bug would've already been present before this change.
| export const listItemRegex = /^(\s*)([*-]|(\d+)\.)(\s{1,2})(?:(\[[\sx]\])\s)?(.*)/i | |
| export const listItemRegex = /^(\s*)([*-]|(\d+)\.)( {1,2})(?:(\[[\sx]\])\s)?(.*)/i |
There was a problem hiding this comment.
\s is identifying tabs as well, i just checked
…r/react into iunia/misspaced-checkboxes
The MD editor is not considering a valid tasklist item a line considering of an item that contains multiple spaces between the
-delimiter and the[ ]textbox. This used to work as expected in the Rails experience - because of the differences in implementation, the[ ]there had a data attribute decorated with the position in the list and was not parsing again the text line, when the textbox was checked.This PR is changing the regex that parses the line and takes into account 1 or 2 spaces that can be present there. i used
{1, 2}instead of*for the repetitions so that we don't consider to be correct tasklist items that are too deformed.Changelog
New
Changed
Regex for identifying a task in a markdown list in order to accept multiple spaces between the delimiter and the box
Removed
Rollout strategy
Testing & Reviewing
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.