-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ActionMenu: Only use checkmarks in menus and improve examples #3994
Conversation
🦋 Changeset detectedLatest commit: f117b6b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
I utilized this search query to determine the effects of my changes on our GitHub platform. I'm currently investigating which product areas will be impacted by this change and will outline them below. I've also included some further insights on implementations that are unaffected but have potential for enhancement. ProjectsIn roadmap project boards, the "milestones" menu will be updated to use checkmarks instead. This change aligns it with other menus, such as the "date fields" menu. However, there's an issue with consistency in how these menus behave. Some close immediately after a selection is made, while others stay open. Ideally, dropdown menus should close once a selection is made. If they need to stay open, a SelectPanel with a dialog and a close button should be used for better accessibility. Action Required: While the above issue is not critical and will just cause a visual update, it's important to notify the projects team to address these inconsistencies. Although my updates won't impact this area, I'd like to mention that I discovered a glitch in the add column feature for boards. The field sum menu will change to checkmarks instead of checkboxes. If they want to keep the option after making a selection instead of using Action Required: The above is not critical since it's only a visual change for them. However the use of Pull requestsThis experience is currently being developed, so modifying the checkmarks is safe. Importantly, this change will be advantageous for this team, as it will ensure the behavior aligns perfectly with what we aim to address in this PR. Notification settings
Resolved through despite the tooltip bug. This bug is unrelated and needs to be resolved separately: ConclusionFrom the 23 file matches on the GitHub platform only 7 will be affected because they are either wrapped in the Internal onlyAffected
Unaffected
|
I believe it's wise to wait for the Notifications and Memex team to adjust to the above changes before we proceed with the merge. |
@joshblack or @siddharthkp, does validating the changes in this PR fall clearly into either of the epics you are directly working on right now given the impact on What do you think? |
Doesn't fall into my path in SelectPanel, sorry! Happy to look into it outside the epic, of course |
@lesliecdubs @joshblack Internally this pull request was merged which unblocks this. Are you both happy to merge this and agree that the above impact is minimal? |
@maximedegreve I'm comfortable with merging if @siddharthkp also approves. Should we verify with @tallys from the design perspective as well? |
Hi 👋 , do you know if the changes you asked for in notifications and memex have been merged? |
@siddharthkp Memex is informed about the updates. However, these won't cause any disruptions because they only alter the appearance. Besides, the current menu behavior there is already inconsistent as described above. |
Closes #3878
Changelog
Before / After
Removed
Rollout strategy
Testing & Reviewing
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.