Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip2: Update direction mapping #4098

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Conversation

broccolinisoup
Copy link
Member

@broccolinisoup broccolinisoup commented Dec 21, 2023

Just realised that the Tooltip v2 se, sw, ne, nw directions are not correct.

What we have vs What is expected.

Changelog

New

Changed

Updated the align property values in the mapping objects based on the info from the behaviours:

  /**
   * Determines how the floating element should align with the anchor element. If
   * set to "start", the floating element's first edge (top or left) will align
   * with the anchor element's first edge. If set to "center", the floating
   * element will be centered along the axis of the anchor edge. If set to "end",
   * the floating element's last edge will align with the anchor element's last edge.
   */

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

All Directions story is a good one to test

Merge checklist

@broccolinisoup broccolinisoup requested review from a team and pksjce December 21, 2023 01:36
Copy link

changeset-bot bot commented Dec 21, 2023

🦋 Changeset detected

Latest commit: c66bc61

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@broccolinisoup broccolinisoup changed the title y Tooltip2: Update direction mapping Dec 21, 2023
Copy link
Contributor

github-actions bot commented Dec 21, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 104.95 KB (+0.01% 🔺)
dist/browser.umd.js 105.52 KB (0%)

Copy link
Contributor

@mperrotti mperrotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would also be nice to follow this up to a change in the Playground story that lets us pick a direction from a predefined list of options instead of accepting any string.

@broccolinisoup
Copy link
Member Author

broccolinisoup commented Dec 22, 2023

It would also be nice to follow this up to a change in the Playground story that lets us pick a direction from a predefined list of options instead of accepting any string.

Oh great feedback! I didn't even realise that it was set as string, sorry my bad. I updated it 🤗

@broccolinisoup broccolinisoup added this pull request to the merge queue Jan 12, 2024
Merged via the queue into main with commit dc97a9b Jan 12, 2024
32 checks passed
@broccolinisoup broccolinisoup deleted the bs/tooltip-direction branch January 12, 2024 05:36
@primer primer bot mentioned this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants