Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SelectPanel2: Add modal variant #4120

Merged
merged 8 commits into from
Jan 22, 2024
Merged

SelectPanel2: Add modal variant #4120

merged 8 commits into from
Jan 22, 2024

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Jan 5, 2024 •
edited
Loading

  • Add modal variant
  • Add modal story to features
  • Update examples story for opening modal SelectPanel from ActionMenu
SelectPanel anchored variant (default) SelectPanel modal variant
SelectPanel is in the centre of the screen SelectPanel is anchored to the button

@siddharthkp siddharthkp self-assigned this Jan 5, 2024
@changeset-bot changeset-bot

This comment was marked as resolved.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 104.96 KB (0%)
dist/browser.umd.js 105.53 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-4120 January 5, 2024 11:16 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4120 January 5, 2024 11:57 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4120 January 5, 2024 12:10 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4120 January 12, 2024 20:52 Inactive
@siddharthkp siddharthkp changed the title SelectPanel2: Add variant: modal SelectPanel2: Add modal variant Jan 12, 2024
@siddharthkp siddharthkp marked this pull request as ready for review January 12, 2024 20:53
@siddharthkp siddharthkp requested a review from a team January 12, 2024 20:53
broccolinisoup
broccolinisoup approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool ✨

@siddharthkp siddharthkp added this pull request to the merge queue Jan 22, 2024
Merged via the queue into main with commit cbdd98a Jan 22, 2024
32 checks passed
@siddharthkp siddharthkp deleted the drafts-selectpanel-modal branch January 22, 2024 18:13
@primer primer bot mentioned this pull request Jan 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broccolinisoup broccolinisoup broccolinisoup approved these changes

@mperrotti mperrotti mperrotti approved these changes

Assignees

@siddharthkp siddharthkp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siddharthkp @broccolinisoup @mperrotti