SelectPanel2: Fix bug calling onCancel #4131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
size-limit report 📦
|
siddharthkp
temporarily deployed
to
github-pages
GitHub Actions
Inactive
siddharthkp
commented
Jan 12, 2024
| if (typeof propsOnCancel === 'function') propsOnCancel() | ||
| } | ||
|
|
||
| const onInternalSubmit = (event?: React.FormEvent<HTMLFormElement>) => { | ||
| event?.preventDefault() // there is no event with selectionVariant=instant | ||
| if (propsOpen === undefined) setInternalOpen(false) |
There was a problem hiding this comment.
don't worry, this line is part of onInternalClose
siddharthkp
commented
Jan 12, 2024
| else dialogRef.current?.close() | ||
|
|
||
| // sync dialog open state (imperative) with internal component state | ||
| React.useEffect(() => { |
There was a problem hiding this comment.
Moved these statements into an effect to avoid conflict with the subsequent lines in the component in the same render
dialog was closing and then the other lines in the component would try to access dialogRef.current which throw an error on the console :)
siddharthkp
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mperrotti
approved these changes
Jan 18, 2024
Comment on lines
167
to
171
| React.useEffect(() => { | ||
| const dialogEl = dialogRef.current | ||
| dialogEl?.addEventListener('close', onInternalClose) | ||
| return () => dialogEl?.removeEventListener('close', onInternalClose) | ||
| }) |
There was a problem hiding this comment.
Do we need these effects to run every render? 🤔
There was a problem hiding this comment.
Good question! I'll double check
| import React from 'react' | ||
| import {ThemeProvider, ActionList} from '../../' | ||
| import {render, RenderResult} from '@testing-library/react' | ||
| import userEvent, {UserEvent} from '@testing-library/user-event' |
There was a problem hiding this comment.
Oo UserEvent type, I've never used it before 🔥
siddharthkp
changed the title
siddharthkp
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
approved these changes
Jan 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: Calling
onSubmitcallsinternalClosewhich callsonCancel🐞!This PR fixes that by separating
internalCloseandinternalCancel