-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SelectPanel2: Add SelectPanel.SecondaryAction #4145
Conversation
siddharthkp
commented
Jan 13, 2024
- Closes https://github.com/github/primer/issues/2379
This comment was marked as resolved.
This comment was marked as resolved.
size-limit report 📦
|
@@ -389,6 +395,7 @@ const SelectPanelSearchInput: React.FC<TextInputProps> = ({onChange: propsOnChan | |||
) | |||
} | |||
|
|||
const FooterContext = React.createContext(false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: we should add a type to the context (probably it is in your to-do but just a reminder 🙂 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated :)
|
||
const SecondaryLink: React.FC<LinkProps> = props => { | ||
return ( | ||
// @ts-ignore TODO: is as prop is not recognised by button? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is but maybe with "a" instead of Link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, that also throws some type errors 🤔
Will put an task to triage and clean up at the end of the project!