Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SelectPanel2: Add SelectPanel.SecondaryAction #4145

Merged
merged 5 commits into from
Jan 23, 2024
Merged

SelectPanel2: Add SelectPanel.SecondaryAction #4145

merged 5 commits into from
Jan 23, 2024

Conversation

siddharthkp
Copy link
Member 

<SelectPanel.Footer>
  <SelectPanel.SecondaryAction variant="button">Edit labels</SelectPanel.SecondaryAction>
</SelectPanel.Footer>
Secondary action button 
<SelectPanel.Footer>
  <SelectPanel.SecondaryAction variant="link">Edit labels</SelectPanel.SecondaryAction>
</SelectPanel.Footer>
Secondary action link 
<SelectPanel.Footer>
  <SelectPanel.SecondaryAction variant="checkbox">Set as default</SelectPanel.SecondaryAction>
</SelectPanel.Footer>
Secondary action checkbox

@changeset-bot changeset-bot

This comment was marked as resolved.

Sign in to view
@siddharthkp siddharthkp self-assigned this Jan 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 13, 2024 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 104.47 KB (0%)
dist/browser.umd.js 105.08 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-4145 January 13, 2024 19:31 Inactive
@siddharthkp siddharthkp marked this pull request as ready for review January 13, 2024 19:33
@siddharthkp siddharthkp requested a review from a team January 13, 2024 19:33
@github-actions github-actions bot temporarily deployed to storybook-preview-4145 January 13, 2024 19:44 Inactive
broccolinisoup
broccolinisoup reviewed Jan 15, 2024
View reviewed changes
src/drafts/SelectPanel2/SelectPanel.tsx Outdated
@@ -389,6 +395,7 @@ const SelectPanelSearchInput: React.FC<TextInputProps> = ({onChange: propsOnChan
)
}

const FooterContext = React.createContext(false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: we should add a type to the context (probably it is in your to-do but just a reminder 🙂 )

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated :)

src/drafts/SelectPanel2/SelectPanel.tsx

const SecondaryLink: React.FC<LinkProps> = props => {
return (
// @ts-ignore TODO: is as prop is not recognised by button?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is but maybe with "a" instead of Link?

Copy link
Member Author

@siddharthkp siddharthkp Jan 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, that also throws some type errors 🤔

Will put an task to triage and clean up at the end of the project!

@siddharthkp siddharthkp added this pull request to the merge queue Jan 23, 2024
Merged via the queue into main with commit 996475f Jan 23, 2024
30 checks passed
@siddharthkp siddharthkp deleted the drafts-selectpanel-secondary-actions branch January 23, 2024 08:11
@primer primer bot mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broccolinisoup broccolinisoup broccolinisoup approved these changes

@mperrotti mperrotti mperrotti approved these changes

Assignees

@siddharthkp siddharthkp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siddharthkp @broccolinisoup @mperrotti