Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Dialog: Full screen & Bottom sheet support" #4177

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Jan 24, 2024

Reverts #4048

When going through the release flow today, the status checks started failing compared to a couple of days ago when I kicked things off. When going through merged commits in the last couple of days, I believe I narrowed it down to #4048 which introduced the breakage based on the integration checks failing for this PR: https://github.com/github/github/pull/309850

Here's a link to example tests that are failing: https://github.com/github/github/actions/runs/7644551659/job/20829185346

It seems like the notable failure is this line (at least in the case of the first batch)

<div role="dialog" width="xlarge" height="large" aria…>…</div> intercepts pointer events

When testing the revert over on dotcom we get green tests again: https://github.com/github/github/pull/309893

Copy link

changeset-bot bot commented Jan 24, 2024

⚠️ No Changeset found

Latest commit: bc9380a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

size-limit report 📦

Path Size
dist/browser.esm.js 104.47 KB (-1.42% 🔽)
dist/browser.umd.js 105.11 KB (-1.46% 🔽)

@joshblack joshblack added this pull request to the merge queue Jan 24, 2024
Merged via the queue into main with commit 96ac939 Jan 24, 2024
36 checks passed
@joshblack joshblack deleted the revert-4048-feature/full-screen-clean branch January 24, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants