Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(SegmentedControl): explicitly set the type attribute for SegmentedControl.Button #4640

Merged
merged 3 commits into from
Jun 5, 2024
Merged

fix(SegmentedControl): explicitly set the type attribute for SegmentedControl.Button #4640

merged 3 commits into from
Jun 5, 2024

Conversation

joshblack
Copy link
Member

Closes https://github.com/github/primer/issues/3308

Changelog

New

Changed

  • Explicitly set the type attribute of the SegmentedControl.Button component to "button" to prevent automatic submission in form elements

Removed

Rollout strategy

  • Minor release

Testing & Reviewing

  • Verify that the SegmentedControl.Button component renders a <button> element with type="button"

@joshblack joshblack requested a review from a team as a code owner June 3, 2024 22:01
@joshblack joshblack requested a review from pksjce June 3, 2024 22:01
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 3, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 44dd91b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 3, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 89.43 KB (-0.02% 🔽)
packages/react/dist/browser.umd.js 89.64 KB (-0.12% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-4640 June 3, 2024 22:05 Inactive
broccolinisoup
broccolinisoup approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need a changeset but the PR is looking great!

@joshblack joshblack enabled auto-merge June 5, 2024 20:18
@github-actions github-actions bot temporarily deployed to storybook-preview-4640 June 5, 2024 20:21 Inactive
@joshblack joshblack added this pull request to the merge queue Jun 5, 2024
Merged via the queue into main with commit 6cbbc49 Jun 5, 2024
30 checks passed
@joshblack joshblack deleted the joshblack-patch-1 branch June 5, 2024 20:43
@primer primer bot mentioned this pull request Jun 5, 2024
Merged
@StemmlerSisters StemmlerSisters mentioned this pull request Jul 16, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Jul 17, 2024
Open
@LLotme LLotme mentioned this pull request Jul 17, 2024
Open
@julitabarelkowska julitabarelkowska mentioned this pull request Jul 17, 2024
Open
@Canadatechmanufacturing Canadatechmanufacturing mentioned this pull request Jul 17, 2024
Open
This was referenced Jul 21, 2024
Open
Merged
This was referenced Aug 2, 2024
Open
Open
@snyk-io snyk-io bot mentioned this pull request Aug 13, 2024
Open
@WontonSam WontonSam mentioned this pull request Aug 16, 2024
Open
@OKEAMAH OKEAMAH mentioned this pull request Aug 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broccolinisoup broccolinisoup broccolinisoup approved these changes

@pksjce pksjce Awaiting requested review from pksjce pksjce is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshblack @broccolinisoup