Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ActionList.Item conditional when FF is not enabled #4695

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

TylerJDev
Copy link
Contributor

Changelog

Changed

Fixes conditional when primer_react_action_list_item_as_button feature flag is not enabled. This allows the forwarded ref to always be present, regardless of the FF being active or not. If the FF is inactive, it defaults to providing the <li> the ref. When the FF is active, applies it to either the <li> or the <button> based on the listSemantics const.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Jun 25, 2024

🦋 Changeset detected

Latest commit: 2a68038

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 25, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 91.01 KB (-0.11% 🔽)
packages/react/dist/browser.umd.js 91.37 KB (+0.03% 🔺)

@joshblack joshblack added this pull request to the merge queue Jun 25, 2024
Merged via the queue into main with commit 9ee8ec9 Jun 25, 2024
30 checks passed
@joshblack joshblack deleted the fix-for-actionlist-semantics branch June 25, 2024 14:50
@primer primer bot mentioned this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants