Add support for initial focus ref to Dialog 2 #4729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2c9eca0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
siddharthkp
reviewed
Jul 10, 2024
| @@ -4,7 +4,7 @@ import {render as HTMLRender, fireEvent} from '@testing-library/react' | |||
| import axe from 'axe-core' | |||
| import {behavesAsComponent, checkExports} from '../utils/testing' | |||
|
|
|||
| /* Dialog Version 2 */ | |||
| /* Dialog Version 1*/ | |||
There was a problem hiding this comment.
This is getting out of our hand now 🤣 I think version 2 tests are this : https://github.com/primer/react/blob/main/packages/react/src/Dialog/Dialog.test.tsx
Confirmed with looking at the APIs as well - I hope we get it right this time 😅 🤞🏻
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
siddharthkp
approved these changes
Jul 11, 2024
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/332713 |
Merged
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reported internally and lack of being able to focus on a specific element when the dialog is open is problematic for some teams. This PR adds support for an
initialFocusRefprop to the Dialog component. (As same as Dialog 1, although parity wasn't the motivation.)Note
We thought about using the native
autoFocusattribute however, there is a known bug about using it in React. We also not sure about our timeline of switching to native dialog, we decided to stick with the current implementation. Let me know if you have any concerns 🙌🏻Changelog
New
initialFocusRefprop. This prop allows you to specify an element that should receive focus when the dialog opens.Rollout strategy
Testing & Reviewing
Merge checklist