refactor(Text): Text component to use CSS modules behind primer_react_css_modules_team feature flag #4874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5628650 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
jonrohan
changed the title
siddharthkp
reviewed
Aug 23, 2024
| @@ -44,6 +44,25 @@ test.describe('Text', () => { | |||
| test('default @vrt', async ({page}) => { | |||
| await visit(page, { | |||
| id: story.id, | |||
| globals: { | |||
| featureFlags: { | |||
| primer_react_css_modules_team: true, | |||
There was a problem hiding this comment.
Quick question: Does this mean we only run these tests with the feature flag on? Or do we run it twice, once with and once without
There was a problem hiding this comment.
Or do we run it twice, once with and once without
Running once with it off and once with it on and comparing them to the same screenshot.
siddharthkp
approved these changes
Aug 27, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/github/primer/issues/3785
Changelog
Changed
Refactoring
Textto use CSS modules behind the primer_react_css_modules_team feature flag.Removed
Rollout strategy
Testing & Reviewing
This will be behind the primer_react_css_modules_team feature flag
Merge checklist