Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ProgressBar: Adjust
ProgressBar.Item
for accessibility #4878base: main
Are you sure you want to change the base?
ProgressBar: Adjust
ProgressBar.Item
for accessibility #4878Changes from 14 commits
16795e3
747354d
b2aa4c3
3cbd244
993204c
6bb59e3
d73c566
344cf29
0ca44f2
c07904e
ecd8774
b6afe92
b153fc9
3a0f019
4823c8e
a2ca83b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would https://react.dev/reference/react/Children#children-count work here as well for getting the length?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this but ran into an issue where non-components would be included in the count:
This resulted in
React.Children.count(children)
to equal 3 😕 This isn't really a big deal, but I noticed this via a conditional in dotcom that was causing an error, and it was because the children were booleans instead of actual components 😅There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this check, would it be enough to check for the presence of children and toggle or is the count important / used somewhere else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now, you can use the
ProgressBar
alone, or with children. If you use it alone, you can apply all the props directly to<ProgressBar>
, but with children, you need to apply them to the individual items.I think I understand the ask, are you asking if we can switch up the current conditional? 🤔