-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix: invisible
Button variant missing background color when disabled
#4928
Conversation
🦋 Changeset detectedLatest commit: 105426a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
@@ -1680,6 +1680,7 @@ exports[`Button styles invisible button appropriately 1`] = ` | |||
cursor: not-allowed; | |||
box-shadow: none; | |||
color: primer.fg.disabled; | |||
background-color: var(--button-invisible-bgColor-disabled,undefined); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What should the fallback value here be? Seems to be showing up as undefined
🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh weird... lemme fix that
Bug fix: invisible button variant missing bg color when disabled