Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing wide CSS + className to Stack #4957

Merged
merged 2 commits into from
Sep 14, 2024
Merged

Add missing wide CSS + className to Stack #4957

merged 2 commits into from
Sep 14, 2024

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Sep 12, 2024 •
edited
Loading

I noticed the wide CSS was missing for the wrap prop. Also adding a className prop 😄

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 36f5057

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to storybook-preview-4957 September 12, 2024 22:13 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 12, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.08 KB (+0.16% 🔺)
packages/react/dist/browser.umd.js 97.32 KB (+0.08% 🔺)

@langermank langermank marked this pull request as ready for review September 13, 2024 00:30
@langermank langermank requested a review from a team as a code owner September 13, 2024 00:30
@langermank langermank added this pull request to the merge queue Sep 13, 2024
Merged via the queue into main with commit 6874b89 Sep 14, 2024
33 checks passed
@langermank langermank deleted the stack-wrap-wide-bug branch September 14, 2024 00:08
@primer primer bot mentioned this pull request Sep 14, 2024
Merged
TylerJDev pushed a commit that referenced this pull request Sep 16, 2024
@langermank @TylerJDev
Add missing wide CSS + className to Stack (#4957)
75b9c20 
* add missing css + classname

* Create fuzzy-jobs-deny.md
TylerJDev pushed a commit that referenced this pull request Sep 23, 2024
@langermank @TylerJDev
Add missing wide CSS + className to Stack (#4957)
ac4369a 
* add missing css + classname

* Create fuzzy-jobs-deny.md
@primer primer bot mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@mperrotti mperrotti Awaiting requested review from mperrotti mperrotti is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@langermank @joshblack